introduce `--no-auth` flag for `setup.sh` and `start.sh` scripts for easier local development

[twrichards]

https://trello.com/c/9qsSL3Am

https://github.com/guardian/grid/pull/3226 was quite confusing and undocumented, here we introduce a new flag --no-auth for the setup.sh and start.sh scripts (which replaces $LOCAL_SIMPLE_AUTH_PROVIDER and better describes the behaviour) and it now changes the auth providers in the generated config rather than re-writing the application.conf file (since that could easily get committed).

NOTE: The --with-local-auth is still potentially broken (I couldn't get it working, and other users outside Guardian have reported problems) - I've created https://trello.com/c/3cF1guts/2825-fix-improve-with-local-auth-option-in-grid-setup-start to revisit this. EDIT: this looks to have been picked up in https://github.com/guardian/grid/pull/3865

[twrichards]

FYI @ochiengolanga @ornel-lloyd-edano

[twrichards]

we should also look at fixing local auth properly, it seems fairly broken at present

@andrew-nowak agreed, hence created https://trello.com/c/3cF1guts/2825-fix-improve-with-local-auth-option-in-grid-setup-start (see PR description). I now see you've made #3865 - amazing. Please could you take an opportunity to refactor the setup script to make all config changes in the generateConfig step (i.e. via the JS project) rather than it using sed to change the application.conf

[andrew-nowak]

Please could you take an opportunity to refactor the setup script to make all config changes in the generateConfig step (i.e. via the JS project) rather than it using sed to change the application.conf

this PR already seems to resolve both instances, I can't see any others in the setup script

[twrichards]

Please could you take an opportunity to refactor the setup script to make all config changes in the generateConfig step (i.e. via the JS project) rather than it using sed to change the application.conf

this PR already seems to resolve both instances, I can't see any others in the setup script

Sorry @andrew-nowak you're completely right 🤦

[prout-bot]

Seen on usage, kahuna, thrall, metadata-editor (merged by @twrichards 15 minutes and 59 seconds ago) Please check your changes!

[prout-bot]

Seen on media-api (merged by @twrichards 16 minutes and 3 seconds ago) Please check your changes!

[prout-bot]

Seen on cropper, image-loader, leases (merged by @twrichards 16 minutes and 7 seconds ago) Please check your changes!

[prout-bot]

Seen on collections (merged by @twrichards 16 minutes and 12 seconds ago) Please check your changes!

[prout-bot]

Seen on auth (merged by @twrichards 16 minutes and 21 seconds ago) Please check your changes!