grid icon indicating copy to clipboard operation
grid copied to clipboard

Get app config from service

Open jamesgorrie opened this issue 10 years ago • 2 comments

Having our config come from Play is not a great dependency.

There is a good discussion going on about it with a few solutions / hacks.

jamesgorrie avatar Dec 12 '14 16:12 jamesgorrie

Pinging @theefer as we we're talking about this yesterday.

kenoir avatar Aug 20 '15 13:08 kenoir

Most of the solutions mentioned in that SO thread are quite hacky or simplistic, in that they expose a promise which means everything depending on that needs to also be made asynchronous. Slightly annoying.

I might take a look at https://github.com/philippd/angular-deferred-bootstrap

In practice, we don't have that much in the HTML file. Mixpanel should be easy to move as it's already initialised asynchronously. Sentry would take a bit more effort. Not much else. So I don't think it's necessarily worth a huge effort to hide away one small half-secret piece of information...

theefer avatar Aug 20 '15 13:08 theefer