grid icon indicating copy to clipboard operation
grid copied to clipboard

Mischievous Chips

Open tsop14 opened this issue 9 years ago • 12 comments

😈🍟 Pasted outstanding issues from below:

  • [ ] duplicate search term after pressing : (here)
  • [ ] embarrassingly reveal the lack of UI responsiveness when cut long enough (here)
  • [ ] pressing - should not immediately launch a chip preventing one from running NOT queries! (here)
  • [ ] collections should be suggested (here)
  • [ ] keyboard navigation between free-text and chips is broken (left, right, tab/shift+tab)
  • [ ] suggestions shouldn’t be scrollable where there is space and navigating them by arrow keys should scroll them
  • [ ] chips don’t work with arbitrary fields, eg. +"fileMetadata.colourModelInformation.hasAlpha":"true"
  • [ ] chips, when committed, end up at the beginning of the search box, ie. try typing cats +fileType:png. This reordering does not affect URL. But it will create problems when order of the search arguments will matter (eg. for OR searches)
- [x] Cannot click into search box in embedded Grid on FF.
- [x] Cannot select text.
- [x] Double-clicking to select all doesn't work if you do it in the are after the word.
- [x] When try to select text with a broad click-drag, depending on where do you start dragging (still: always within the text box area), different glitches happen in different browsers... 
- [x] Cannot Paste (from the context menu).  
- [x] Struggling to insert my cursor into the search field or to highlight the words in order to edit them.

tsop14 avatar Mar 04 '16 10:03 tsop14

  • [x] :fries: do not play well with usages@ syntax. usages falls out of a chip that only says e.g. status: and @ is hidden and... just have a play :) Also, none of usage stuff is offered in a suggestion after typing +

paperboyo avatar Mar 05 '16 21:03 paperboyo

  • [x] :fries: bleed out of the searchbox on latest beta and nightly of Firefox on Win10 like so:

chips bleed

paperboyo avatar Mar 06 '16 22:03 paperboyo

:fries: they're trying to be clever with nested queries

  • [ ] query limited to size of chip when it aint a chip! (can't reproduce, just keep an eye out)
  • [x] when I do a nested query, click on an image, and then go back to search, chips kick in incorrectly the query in the example below was "usages@>added:2015" screen shot 2016-03-07 at 12 27 40

NickPapacostas avatar Mar 07 '16 12:03 NickPapacostas

  • [ ] :fries: embarrassingly reveal the lack of UI responsiveness when cut long enough:

chips-long

[EDIT: if there are too many :fries:, the filters are not available at all]:

0e863246-2987-11e6-806b-c94539cd7f79

paperboyo avatar Mar 30 '16 08:03 paperboyo

  • [x] ~~Trying to add a # at the beginning of the search term (sound effects are: aaarrrrgh!! and nooooo!):~~ [Fixed in the future by https://github.com/guardian/grid/pull/1830)

untitled

paperboyo avatar Apr 01 '16 14:04 paperboyo

Think #1830 will fix this?

tsop14 avatar Apr 01 '16 14:04 tsop14

Oh cool, haven't connected the dots, sorry! Can I have a play with crop, pretty please (at any point, incl. when it's in PROD ;-) ).

paperboyo avatar Apr 01 '16 14:04 paperboyo

Yep, the branch will do this 👇 add label

tsop14 avatar Apr 01 '16 14:04 tsop14

  • [ ] Collections are not suggested. Also while trying to force them into a chip - my chip died. A dead :fries:

dead chip

paperboyo avatar Apr 07 '16 14:04 paperboyo

  • [ ] :fries: duplicate search term after pressing :

chips colon

P.s. I’m not against :fries:! I love :fries:. It’s a pity they do not always love me back...

paperboyo avatar Apr 17 '16 22:04 paperboyo

Make them work like in PFI where typing + and - does not immediately launch a chip preventing one from running NOT queries.

paperboyo avatar Aug 23 '18 13:08 paperboyo

+title: cannot manually type the name of the filter followed by a colon, eg title: nor can you select +t and get offered this search on the dropdown relating to chips starting with t. Nor does title appear on the hint, listing Currently the only place you can start a search against a title text is from the info panel ,when the image has a title text.

craigh04 avatar Jun 29 '23 08:06 craigh04