frontend
frontend copied to clipboard
Allow adverts to be inserted between comments slots on mobile crossword pages
What is the value of this and can you measure success?
- A positive impact on revenue
What does this change?
- Allows ads to be inserted by the commercial code on mobile crossword pages, by using Custom Events.
- Fires a
comments-loaded
custom event when comments have loaded - Fires a
comments-state-change
custom event when the either of the following has changed- The comments page
- The comments sort order
Note: It may be easier to review this commit by commit: The first commit is prettier, the following have the (few) changes
Screenshots
Before | After |
---|---|
Checklist
- [x] Tested locally, and on CODE if necessary
- [x] Will not break dotcom-rendering
- [x] Will not break our database – if updating CAPI, updated and committed the database files
- [x] Meets our accessibility standards
Seen on ADMIN-PROD (merged by @domlander 13 minutes and 36 seconds ago)
- Check your changes on www.theguardian.com ✔️
- Keep an eye on the deploy dashboard 📉
Seen on FRONTS-PROD (merged by @domlander 13 minutes and 46 seconds ago)
- Check your changes on www.theguardian.com ✔️
- Keep an eye on the deploy dashboard 📉