frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Use www. url in `linkedData` when rendering non amp pages

Open jamesgorrie opened this issue 3 years ago • 2 comments
trafficstars

What does this change?

Fixes https://github.com/guardian/frontend/issues/25262

Changes the @id of the Schema JSON from https://amp.theguardian.com/{id} to https://www.theguardian.com/{id} when we are not on AMP pages.

This is how it was represented on frontend, and is also best practise.

Screenshots

Frontend

URL: https://www.theguardian.com/politics/2022/sep/21/liz-truss-dismisses-putins-nuclear-threats-as-statement-of-weakness?dcr=false

Screenshot 2022-09-22 at 11 57 56

Before

before

After

after

jamesgorrie avatar Sep 22 '22 10:09 jamesgorrie

@OllysCoding

whether it would impact the discoverability of AMP pages?

I think you're right in the sense of that AMP articles should use the prop explicitly meant to expose AMP articles. If this were to affect that, would you expect AMP articles to stop being exposed in Google (just trying to think of a test)?

jamesgorrie avatar Sep 22 '22 13:09 jamesgorrie

Marking as draft while we think about how we might validate this doesn't affect things negatively.

jamesgorrie avatar Sep 22 '22 13:09 jamesgorrie

Seen on PROD (merged by @jamesgorrie 15 minutes and 54 seconds ago)

prout-bot avatar Oct 04 '22 12:10 prout-bot