frontend
frontend copied to clipboard
Are we still using Formstack?
ISSUE
It was recently raised that we're looking to consolidate all our formstack tokens under one enterprise account. We seemingly use Formstack in our Identity application https://github.com/guardian/frontend/blob/95faf36910c217f490e014788905260dda70a0c0/identity/app/controllers/FormstackController.scala but it seemingly receives very little traffic and has expired Formstack tokens.
Do we still need to keep this integration? I'm not entirely sure what its purpose is. Doing a bit of commit digging it seems like it might be used for identity forms eg password reset
It seems there is 33 HTTP 200 over a two week period for form requests to the FormstackController routes
This is odd as the switch is off?
I wonder if we could try figure this out and remove the code.
/form/2020-03-06/cranbourne
/form/mon-projet
/form/jobba-eller-praktisera-hos-oss
/form/plaintone/4135
/form/nxE5QxfmAwah9bt
/form/hkk5S50Hp4K
/form/2020-02-22/bet365-yarra-valley
/form/contact-us/information-request-form
/form/wishlist
/form/website-feedback
/form/summer-training-internships-form
/form/join-our-mailing-list
/form/2nMfIuWHtZqtzzw4C
/form/2020-02-22/caulfield
Comment from James: Basically in terms of the dependency on the formstack team, the keys we have don't exist in either the legacy account, nor new one, so we haven't got anything to do there. We should probably just remove this code for hygiene.
To note: the switch is actually ON in the frontend panel.
I think that this endpoint is always returning 200 + an internal redirect, so logs show a 200 status even though the end user sees a 404 page.
@jamesgorrie and @Georges-GNM to investigate next week?
As per our triaging, this is a high impact issue so ideally we should look at it
My understanding of this issue is that we used to embed forms hosted by Formstack to enable readers to get in touch with more information about a story. This functionality has been migrated to Callouts, where we render the form. Callout forms submit to our Callouts API, which sends data to Formstack. Callouts only work on DCR; they do not work on Frontend.
The functionality to render a Formstack form is in FormstackController
^1, and it is behind the IdentityFormstackSwitch
switch ^2.
I think we could turn the IdentityFormstackSwitch
off because:
- old Formstack embeds have expired. For the ones I have found, you cannot submit new responses to them
- I think editorial are no longer creating Formstack embeds in this way, but rather using the new callouts mechanism.