frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Side nav regression on frontend / DCR

Open jamesgorrie opened this issue 3 years ago • 5 comments

reported by: Mateusz Karpow via: chat https://chat.google.com/room/AAAAG9rU0m0/L9MoJNm-tMQ (internal) on: 21 Feb 2022

Was just looking that Apps, in their side nav manu, solved this dilemma: https://github.com/guardian/frontend/pull/14548#issuecomment-251123272 https://github.com/guardian/frontend/pull/17020#discussion_r120365693 differently to dotcom (I preferred dotcom’s way, which, after toying with a home icon, just made second-after-expanding tap/click go to section IIRC).

But then noticed dotcom (both frontend and DCR) must have a regression here, because it’s impossible to use the side nav on mobile breakpoints to get to main section fronts at all (eg. to https://www.theguardian.com/uk/sport).

Must have been like this for a while, but wanted to mention, because it seems wrong as is.

jamesgorrie avatar Feb 22 '22 13:02 jamesgorrie

@paperboyo could you give a video / screenshot please?

jamesgorrie avatar Feb 22 '22 13:02 jamesgorrie

With an amazing radio-voice from Yors Truly:

https://user-images.githubusercontent.com/6032869/155156067-ee36f6a0-a128-448f-8848-19d054291b8c.mp4

paperboyo avatar Feb 22 '22 14:02 paperboyo

@HarryFischer Do you have any thoughts on this?

OllysCoding avatar Mar 11 '22 10:03 OllysCoding

I'll have a think

HarryFischer avatar Mar 11 '22 10:03 HarryFischer

Updated design here: https://www.figma.com/file/V8u2r27TFdjAWNM3p84ypC/%E2%9C%AD-Header-%26-footer?node-id=0%3A1

HarryFischer avatar Mar 16 '22 14:03 HarryFischer

Looks like this has been fixed

rhiannareechaye avatar Apr 27 '23 13:04 rhiannareechaye