dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Gutters

Open JamieB-gu opened this issue 2 years ago • 9 comments

The Ideal

## TODO
- [ ] Articles to have 12px gutters (as per apps)

To check in with design

  • [ ] Fronts to have 16px gutters
  • [ ] Both go to 20px gutters at mobile landscape (480px)

Work To Do

Apps already follow these rules, so the changes are for dotcom (DCR). https://docs.google.com/document/d/1UaNHA1gHlvmXxzY5-UgXfx-w4mFrJI-x5ljk54OGyYk/edit#heading=h.lbz9nzm7oeta

JamieB-gu avatar Mar 13 '23 16:03 JamieB-gu

This is probably going to be a big change as it's linked to Fronts

rhiannareechaye avatar Mar 30 '23 16:03 rhiannareechaye

double check how large - this may become a mega ticket and needs some more analysis

VDuczekW avatar Aug 09 '23 09:08 VDuczekW

@VDuczekW set up meet

VDuczekW avatar Aug 09 '23 09:08 VDuczekW

do articles first - with the above measurements - will check re Fronts

VDuczekW avatar Aug 14 '23 09:08 VDuczekW

After a catch up on this options are

  • Do nothing until DCAR is complete, and then readdress when the majority is rendered by the same platform (this would lead to inconsistencies while we migrate AR into DCAR)
  • Update everything to be the same now, which is a decent amount of work (probably not too complicated, but large)

If we make chances to articles, we should do it to fronts as well. I'll try and compile a list of current differences and break down how big the change might be

sophie-macmillan avatar Aug 16 '23 09:08 sophie-macmillan

Current Behaviour

Apps DCR AR Frontend
Articles 12px 20px 20px
Fronts 16px 20px 20px

Desired Behaviour: Everything should match apps

Questions

  • How we handle content that’s similar between both articles and fronts, like the header and nav. Do they use 12px on articles and 16px on fronts? What effect will that have on the transition for users navigating between them?
  • Design to confirm the desired gutter size for fronts
  • Design to confirm the desired gutter size for both fronts and articles on mobile

sophie-macmillan avatar Aug 16 '23 11:08 sophie-macmillan

Currently the design requirement is for Fronts and articles to have different gutter sizes - we want to double check this is still the requirement as we anticipate it could look a bit odd when users change from fronts to articles - @HarryFischer can you help

rhiannareechaye avatar Aug 22 '23 13:08 rhiannareechaye

Once we've confirmed on the design requirement we can work out how best to deliver this (FYI we're being careful with this one as it's a fundamental part of our design system so we want to make sure we cover all bases)

rhiannareechaye avatar Aug 22 '23 13:08 rhiannareechaye

We have multiple gutters (dotcom is 10, apps is 12 on articles and 16 on fronts) We can’t make it all 16 as it messes up dotcom fronts Lets go for with 10 for now for dotcom articles and apps articles, and then revisit when we look on Fronts in general on web (the aim would be to make the adjustment to 16 for everything)

rhiannareechaye avatar Sep 14 '23 09:09 rhiannareechaye