Email signup title text

[dblatcher]

What does this change?

• Changes the format of the title for the EmailSignUp component to: "Sign up to [the] {displayName} newsletter" (adding the if the displayName does not already start with "the").
• Adds an extra story to cover a newsletter not starting with "the".
• puts tests on the function generating the title markup

Why?

We've had some feedback that the embed doesn't say 'newsletter' on it anywhere, and have been asked to make it clearer what they are for.

Screenshots

Before	After

[github-actions[bot]]

Size Change: +158 B (0%)

Total Size: 1.62 MB

Filename	Size	Change
dotcom-rendering/dist/frontend.server.js	485 kB	+158 B (0%)

ℹ️ View Unchanged

Filename	Size
dotcom-rendering/dist/1382.legacy.********************.js	5.67 kB
dotcom-rendering/dist/1815.legacy.********************.js	30.9 kB
dotcom-rendering/dist/2344.legacy.********************.js	2.77 kB
dotcom-rendering/dist/259.legacy.********************.js	3.24 kB
dotcom-rendering/dist/286.********************.js	23.2 kB
dotcom-rendering/dist/286.legacy.********************.js	23.9 kB
dotcom-rendering/dist/2947.********************.js	2.74 kB
dotcom-rendering/dist/2947.legacy.********************.js	2.82 kB
dotcom-rendering/dist/3210.********************.js	7.83 kB
dotcom-rendering/dist/3210.legacy.********************.js	8.58 kB
dotcom-rendering/dist/3307.********************.js	3.11 kB
dotcom-rendering/dist/3419.legacy.********************.js	6.34 kB
dotcom-rendering/dist/3584.********************.js	1.8 kB
dotcom-rendering/dist/3584.legacy.********************.js	1.8 kB
dotcom-rendering/dist/4019.********************.js	3.44 kB
dotcom-rendering/dist/4019.legacy.********************.js	3.48 kB
dotcom-rendering/dist/5058.********************.js	2.72 kB
dotcom-rendering/dist/5436.legacy.********************.js	2.68 kB
dotcom-rendering/dist/5553.********************.js	2.85 kB
dotcom-rendering/dist/5887.********************.js	5.93 kB
dotcom-rendering/dist/6101.********************.js	32.9 kB
dotcom-rendering/dist/6131.********************.js	4.29 kB
dotcom-rendering/dist/6131.legacy.********************.js	4.3 kB
dotcom-rendering/dist/6204.********************.js	5.54 kB
dotcom-rendering/dist/6400.********************.js	21.5 kB
dotcom-rendering/dist/6400.legacy.********************.js	21.5 kB
dotcom-rendering/dist/7137.legacy.********************.js	6.39 kB
dotcom-rendering/dist/7148.********************.js	6.8 kB
dotcom-rendering/dist/7148.legacy.********************.js	7.31 kB
dotcom-rendering/dist/7576.********************.js	3.96 kB
dotcom-rendering/dist/7576.legacy.********************.js	5.38 kB
dotcom-rendering/dist/7800.********************.js	11.3 kB
dotcom-rendering/dist/7829.********************.js	2.8 kB
dotcom-rendering/dist/7829.legacy.********************.js	2.91 kB
dotcom-rendering/dist/7981.********************.js	4.31 kB
dotcom-rendering/dist/8129.legacy.********************.js	11.8 kB
dotcom-rendering/dist/8195.legacy.********************.js	2.98 kB
dotcom-rendering/dist/8414.********************.js	4.27 kB
dotcom-rendering/dist/8414.legacy.********************.js	4.34 kB
dotcom-rendering/dist/8471.legacy.********************.js	5.45 kB
dotcom-rendering/dist/8492.legacy.********************.js	4.39 kB
dotcom-rendering/dist/8612.********************.js	3.72 kB
dotcom-rendering/dist/8612.legacy.********************.js	4.21 kB
dotcom-rendering/dist/8808.********************.js	5.3 kB
dotcom-rendering/dist/9380.legacy.********************.js	2.82 kB
dotcom-rendering/dist/AlreadyVisited-importable.********************.js	4.52 kB
dotcom-rendering/dist/AlreadyVisited-importable.legacy.********************.js	4.52 kB
dotcom-rendering/dist/atomIframe.********************.js	757 B
dotcom-rendering/dist/atomIframe.legacy.********************.js	806 B
dotcom-rendering/dist/AudioAtomWrapper-importable.********************.js	459 B
dotcom-rendering/dist/AudioAtomWrapper-importable.legacy.********************.js	517 B
dotcom-rendering/dist/bootCmp.********************.js	8.88 kB
dotcom-rendering/dist/bootCmp.legacy.********************.js	12.5 kB
dotcom-rendering/dist/Branding-importable.********************.js	4.63 kB
dotcom-rendering/dist/Branding-importable.legacy.********************.js	4.64 kB
dotcom-rendering/dist/braze-web-sdk-core.********************.js	36.1 kB
dotcom-rendering/dist/braze-web-sdk-core.legacy.********************.js	36.1 kB
dotcom-rendering/dist/BrazeMessaging-importable.********************.js	9.44 kB
dotcom-rendering/dist/BrazeMessaging-importable.legacy.********************.js	10.1 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.********************.js	4.26 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.legacy.********************.js	4.55 kB
dotcom-rendering/dist/Carousel-importable.********************.js	11.7 kB
dotcom-rendering/dist/Carousel-importable.legacy.********************.js	12.1 kB
dotcom-rendering/dist/ChartAtomWrapper-importable.********************.js	261 B
dotcom-rendering/dist/ChartAtomWrapper-importable.legacy.********************.js	271 B
dotcom-rendering/dist/CommentCount-importable.********************.js	3.45 kB
dotcom-rendering/dist/CommentCount-importable.legacy.********************.js	3.54 kB
dotcom-rendering/dist/CommercialMetrics-importable.********************.js	6.33 kB
dotcom-rendering/dist/CommercialMetrics-importable.legacy.********************.js	777 B
dotcom-rendering/dist/CoreVitals-importable.********************.js	6.06 kB
dotcom-rendering/dist/CoreVitals-importable.legacy.********************.js	6.27 kB
dotcom-rendering/dist/debug.js	1.75 kB
dotcom-rendering/dist/DiscussionContainer-importable.********************.js	3.5 kB
dotcom-rendering/dist/DiscussionContainer-importable.legacy.********************.js	3.75 kB
dotcom-rendering/dist/DiscussionMeta-importable.********************.js	3.93 kB
dotcom-rendering/dist/DiscussionMeta-importable.legacy.********************.js	4.04 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.********************.js	2.99 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.legacy.********************.js	3.1 kB
dotcom-rendering/dist/dynamicImport.********************.js	2 kB
dotcom-rendering/dist/dynamicImport.legacy.********************.js	2.07 kB
dotcom-rendering/dist/EditionDropdown-importable.********************.js	4.1 kB
dotcom-rendering/dist/EditionDropdown-importable.legacy.********************.js	4.15 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.********************.js	3.34 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.legacy.********************.js	3.45 kB
dotcom-rendering/dist/embedIframe.********************.js	759 B
dotcom-rendering/dist/embedIframe.legacy.********************.js	810 B
dotcom-rendering/dist/EnhancePinnedPost-importable.********************.js	6.24 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.legacy.********************.js	6.83 kB
dotcom-rendering/dist/FetchCommentCounts-importable.********************.js	1.73 kB
dotcom-rendering/dist/FetchCommentCounts-importable.legacy.********************.js	1.78 kB
dotcom-rendering/dist/FetchOnwardsData-importable.********************.js	2.22 kB
dotcom-rendering/dist/FetchOnwardsData-importable.legacy.********************.js	2.21 kB
dotcom-rendering/dist/FilterButton-importable.********************.js	2.63 kB
dotcom-rendering/dist/FilterButton-importable.legacy.********************.js	2.73 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.********************.js	3.82 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.legacy.********************.js	3.89 kB
dotcom-rendering/dist/FocusStyles-importable.********************.js	4.71 kB
dotcom-rendering/dist/FocusStyles-importable.legacy.********************.js	4.77 kB
dotcom-rendering/dist/ga.********************.js	2.83 kB
dotcom-rendering/dist/ga.legacy.********************.js	2.9 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.********************.js	4 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.legacy.********************.js	4.18 kB
dotcom-rendering/dist/GetMatchNav-importable.********************.js	9.22 kB
dotcom-rendering/dist/GetMatchNav-importable.legacy.********************.js	9.48 kB
dotcom-rendering/dist/GetMatchStats-importable.********************.js	6.35 kB
dotcom-rendering/dist/GetMatchStats-importable.legacy.********************.js	7.13 kB
dotcom-rendering/dist/GetMatchTabs-importable.********************.js	3.07 kB
dotcom-rendering/dist/GetMatchTabs-importable.legacy.********************.js	3.23 kB
dotcom-rendering/dist/guardian-braze-components-banner.********************.js	11.3 kB
dotcom-rendering/dist/guardian-braze-components-banner.js	10.3 kB
dotcom-rendering/dist/guardian-braze-components-banner.legacy.********************.js	11.4 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.********************.js	9.28 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.js	9.75 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.********************.js	9.36 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.********************.js	263 B
dotcom-rendering/dist/GuideAtomWrapper-importable.legacy.********************.js	273 B
dotcom-rendering/dist/initDiscussion.********************.js	10.9 kB
dotcom-rendering/dist/initDiscussion.legacy.********************.js	11.2 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.********************.js	3 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.legacy.********************.js	3.09 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.********************.js	4.26 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.legacy.********************.js	4.43 kB
dotcom-rendering/dist/islands.********************.js	11.1 kB
dotcom-rendering/dist/islands.legacy.********************.js	11.9 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.********************.js	2.9 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.legacy.********************.js	3.01 kB
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.********************.js	268 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.legacy.********************.js	280 B
dotcom-rendering/dist/LabsHeader-importable.********************.js	8.66 kB
dotcom-rendering/dist/LabsHeader-importable.legacy.********************.js	8.79 kB
dotcom-rendering/dist/Links-importable.********************.js	6.32 kB
dotcom-rendering/dist/Links-importable.legacy.********************.js	7.38 kB
dotcom-rendering/dist/LiveBlogEpic-importable.********************.js	5.51 kB
dotcom-rendering/dist/LiveBlogEpic-importable.legacy.********************.js	6.18 kB
dotcom-rendering/dist/Liveness-importable.********************.js	3.58 kB
dotcom-rendering/dist/Liveness-importable.legacy.********************.js	3.65 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.********************.js	5.1 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.legacy.********************.js	5.33 kB
dotcom-rendering/dist/MostViewedFooterData-importable.********************.js	7.59 kB
dotcom-rendering/dist/MostViewedFooterData-importable.legacy.********************.js	7.74 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.********************.js	6.96 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.legacy.********************.js	4.94 kB
dotcom-rendering/dist/newsletterEmbedIframe.********************.js	933 B
dotcom-rendering/dist/newsletterEmbedIframe.legacy.********************.js	972 B
dotcom-rendering/dist/OnwardsUpper-importable.********************.js	6.1 kB
dotcom-rendering/dist/OnwardsUpper-importable.legacy.********************.js	6.33 kB
dotcom-rendering/dist/ophan.********************.js	7.14 kB
dotcom-rendering/dist/ophan.legacy.********************.js	7.37 kB
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.********************.js	271 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.legacy.********************.js	282 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.********************.js	264 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.legacy.********************.js	274 B
dotcom-rendering/dist/PulsingDot-importable.********************.js	1.66 kB
dotcom-rendering/dist/PulsingDot-importable.legacy.********************.js	1.76 kB
dotcom-rendering/dist/QandaAtomWrapper-importable.********************.js	262 B
dotcom-rendering/dist/QandaAtomWrapper-importable.legacy.********************.js	272 B
dotcom-rendering/dist/ReaderRevenueDev-importable.********************.js	4.58 kB
dotcom-rendering/dist/ReaderRevenueDev-importable.legacy.********************.js	4.6 kB
dotcom-rendering/dist/readerRevenueDevUtils.********************.js	3.19 kB
dotcom-rendering/dist/readerRevenueDevUtils.js	2.33 kB
dotcom-rendering/dist/readerRevenueDevUtils.legacy.********************.js	4.23 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.********************.js	5.13 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.legacy.********************.js	5.53 kB
dotcom-rendering/dist/relativeTime.********************.js	1.3 kB
dotcom-rendering/dist/relativeTime.legacy.********************.js	1.35 kB
dotcom-rendering/dist/RichLinkComponent-importable.********************.js	5.71 kB
dotcom-rendering/dist/RichLinkComponent-importable.legacy.********************.js	5.84 kB
dotcom-rendering/dist/SecureSignupIframe-importable.********************.js	8.43 kB
dotcom-rendering/dist/SecureSignupIframe-importable.legacy.********************.js	8.76 kB
dotcom-rendering/dist/sentry.********************.js	684 B
dotcom-rendering/dist/sentry.legacy.********************.js	691 B
dotcom-rendering/dist/sentryLoader.********************.js	10.1 kB
dotcom-rendering/dist/sentryLoader.legacy.********************.js	14.1 kB
dotcom-rendering/dist/SetABTests-importable.********************.js	8.11 kB
dotcom-rendering/dist/SetABTests-importable.legacy.********************.js	2.74 kB
dotcom-rendering/dist/ShareCount-importable.********************.js	3.58 kB
dotcom-rendering/dist/ShareCount-importable.legacy.********************.js	3.69 kB
dotcom-rendering/dist/shimport.********************.js	2.78 kB
dotcom-rendering/dist/shimport.legacy.********************.js	2.79 kB
dotcom-rendering/dist/ShowHideContainers-importable.********************.js	662 B
dotcom-rendering/dist/ShowHideContainers-importable.legacy.********************.js	700 B
dotcom-rendering/dist/SignInGateMain.********************.js	4.48 kB
dotcom-rendering/dist/SignInGateMain.js	2.87 kB
dotcom-rendering/dist/SignInGateMain.legacy.********************.js	4.56 kB
dotcom-rendering/dist/SignInGateSelector-importable.********************.js	5.19 kB
dotcom-rendering/dist/SignInGateSelector-importable.legacy.********************.js	5.47 kB
dotcom-rendering/dist/SlotBodyEnd-importable.********************.js	2.29 kB
dotcom-rendering/dist/SlotBodyEnd-importable.legacy.********************.js	2.93 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.********************.js	5.02 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.legacy.********************.js	5.25 kB
dotcom-rendering/dist/StickyBottomBanner-importable.********************.js	6.85 kB
dotcom-rendering/dist/StickyBottomBanner-importable.legacy.********************.js	7.84 kB
dotcom-rendering/dist/SubNav-importable.********************.js	3.25 kB
dotcom-rendering/dist/SubNav-importable.legacy.********************.js	3.37 kB
dotcom-rendering/dist/TimelineAtomWrapper-importable.********************.js	262 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.legacy.********************.js	273 B
dotcom-rendering/dist/TopicFilterBank-importable.********************.js	3.71 kB
dotcom-rendering/dist/TopicFilterBank-importable.legacy.********************.js	3.83 kB
dotcom-rendering/dist/TopRightAdSlot-importable.********************.js	1.99 kB
dotcom-rendering/dist/TopRightAdSlot-importable.legacy.********************.js	2.02 kB
dotcom-rendering/dist/TweetBlockComponent-importable.********************.js	1.8 kB
dotcom-rendering/dist/TweetBlockComponent-importable.legacy.********************.js	1.79 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.********************.js	3.01 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.legacy.********************.js	3.11 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.********************.js	5.11 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.legacy.********************.js	5.33 kB
dotcom-rendering/dist/VineBlockComponent-importable.********************.js	2.81 kB
dotcom-rendering/dist/VineBlockComponent-importable.legacy.********************.js	2.91 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.********************.js	5.68 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.legacy.********************.js	5.98 kB

_{compressed-size-action}

[github-actions[bot]]

⚡️ Lighthouse report for the changes in this PR

Lighthouse tested 2 URLs

⚠️ Budget exceeded for 4 of 10 audits.

Report for Article

tested url https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left

Category	Status	Expected	Actual
First Contentful Paint	✅	1500	1200
Largest Contentful Paint	✅	3000	1724
Time to Interactive	✅	3500	2327
Cumulative Layout Shift	⚠️	0.002	0.004428
accessibility	✅	0.97	1.000000

Report for Front

tested url https://www.theguardian.com/uk

Category	Status	Expected	Actual
First Contentful Paint	✅	1500	1204
Largest Contentful Paint	⚠️	3000	95107
Time to Interactive	⚠️	3500	462676
Cumulative Layout Shift	✅	0.002	0.000000
accessibility	⚠️	0.97	0.890000

[dblatcher]

Have seen that Rhianna changed the frequency displayed of the "every weekday" ones to "Free daily newsletter" which I sort of remember us discussing as a suitable approximation, though I'm not sure if we should double check this or not!

Good point - We could special case "every weekday" to "Free daily newsletter", but might be best to check on that.

[dblatcher]

added the update to support "every weekday" and re-synced with main