dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Support Identity Team with Discussion Frontend

Open JamieB-gu opened this issue 1 year ago • 5 comments

JamieB-gu avatar Jun 24 '24 17:06 JamieB-gu

This repo is deprecated and is also using deprecated identity functionality: https://github.com/guardian/discussion-frontend

It is responsible for the comment count and sign in / profile avatar info for articles that are still rendered by frontend and have discussion enabled.

image

Moving forward we have three options:

  1. Temporarily remove this piece of functionality until we can migrate these articles to DCAR. Draft PR: https://github.com/guardian/frontend/pull/27427
  2. Re-write this functionality in frontend and update the identity code. The old code is using an old identity api cookie.
  3. Migrate crosswords, galleries and audio articles to DCAR.

ioannakok avatar Aug 20 '24 16:08 ioannakok

@shesah and @CDicksonG to speak to the I&T team to see which option from above is best.

shesah avatar Aug 22 '24 09:08 shesah

From this document by the Identity team:

"Each crossword page has a comment section. This section makes two calls to our legacy platform using legacy identity cookies, which are then returned in headers. The two calls originate from:

  1. The comment feed
  2. The ‘Signed in as…’ component in the left-hand sidebar"

From our investigation, we think the calls are made only by this section, not by the comment feed.

image

@JamieB-gu do you perhaps know why they're saying one of the calls comes from the comment feed?

ioannakok avatar Aug 23 '24 14:08 ioannakok

We will clarify exactly what we need to turn off and then have conversations with the right people in Editorial

CDicksonG avatar Aug 27 '24 10:08 CDicksonG

@JamieB-gu and myself clarified today with @pvighi that we only need to turn off the box with the comment count and avatar info highlighted in the screenshots above. This will happen only for articles that are still rendered by frontend, i.e. crosswords, galleries and audio articles.

ioannakok avatar Aug 27 '24 17:08 ioannakok