dotcom-rendering
dotcom-rendering copied to clipboard
Published
20 hours ago •
guardian
guardian
Always show `LabsSection` component if front collection is "branded"
What does this change?
Removes the condition renderAds in the logic to decide whether to render a LabsSection
Why?
When renderAds is false, it's not that we don't show the labs section at all, it's that we show a "standard" section instead i.e. a non-labs branded section. This results in a substandard experience viewing the Guardian Labs front as the titles are unreadable due to the lack of sufficient contrast between the text and background.
The following thread is from the initial implementation of this logic: https://github.com/guardian/dotcom-rendering/pull/7813/files#r1219703824
Screenshots
| Before | After |
|---|---|
Size Change: 0 B
Total Size: 761 kB
ℹ️ View Unchanged
| Filename | Size |
|---|---|
dotcom-rendering/dist/112.client.web.********************.js |
822 B |
dotcom-rendering/dist/1148.client.web.********************.js |
5.75 kB |
dotcom-rendering/dist/1191.client.web.********************.js |
680 B |
dotcom-rendering/dist/133.client.web.********************.js |
3 kB |
dotcom-rendering/dist/1405.client.web.********************.js |
3.21 kB |
dotcom-rendering/dist/1407.client.web.********************.js |
640 B |
dotcom-rendering/dist/1459.client.web.********************.js |
876 B |
dotcom-rendering/dist/1742.client.web.********************.js |
6.02 kB |
dotcom-rendering/dist/1749.client.web.********************.js |
920 B |
dotcom-rendering/dist/2030.client.web.********************.js |
2.94 kB |
dotcom-rendering/dist/2293.client.web.********************.js |
582 B |
dotcom-rendering/dist/2380.client.web.********************.js |
2.54 kB |
dotcom-rendering/dist/2443.client.web.********************.js |
4.81 kB |
dotcom-rendering/dist/253.client.web.********************.js |
4.19 kB |
dotcom-rendering/dist/2537.client.web.********************.js |
10 kB |
dotcom-rendering/dist/2554.client.web.********************.js |
3.69 kB |
dotcom-rendering/dist/2712.client.web.********************.js |
3.88 kB |
dotcom-rendering/dist/2770.client.web.********************.js |
530 B |
dotcom-rendering/dist/2819.client.web.********************.js |
4.6 kB |
dotcom-rendering/dist/2832.client.web.********************.js |
5.89 kB |
dotcom-rendering/dist/3313.client.web.********************.js |
3.77 kB |
dotcom-rendering/dist/3363.client.web.********************.js |
4.85 kB |
dotcom-rendering/dist/3375.client.web.********************.js |
2.7 kB |
dotcom-rendering/dist/3876.client.web.********************.js |
17.9 kB |
dotcom-rendering/dist/393.client.web.********************.js |
920 B |
dotcom-rendering/dist/3986.client.web.********************.js |
495 B |
dotcom-rendering/dist/4040.client.web.********************.js |
650 B |
dotcom-rendering/dist/4045.client.web.********************.js |
643 B |
dotcom-rendering/dist/405.client.web.********************.js |
914 B |
dotcom-rendering/dist/4199.client.web.********************.js |
3.14 kB |
dotcom-rendering/dist/4269.client.web.********************.js |
668 B |
dotcom-rendering/dist/4304.client.web.********************.js |
3.56 kB |
dotcom-rendering/dist/4390.client.web.********************.js |
508 B |
dotcom-rendering/dist/4438.client.web.********************.js |
801 B |
dotcom-rendering/dist/4442.client.web.********************.js |
714 B |
dotcom-rendering/dist/478.client.web.********************.js |
595 B |
dotcom-rendering/dist/4792.client.web.********************.js |
3.67 kB |
dotcom-rendering/dist/4870.client.web.********************.js |
748 B |
dotcom-rendering/dist/4880.client.web.********************.js |
2.89 kB |
dotcom-rendering/dist/4911.client.web.********************.js |
780 B |
dotcom-rendering/dist/4993.client.web.********************.js |
23.4 kB |
dotcom-rendering/dist/5005.client.web.********************.js |
3.41 kB |
dotcom-rendering/dist/5020.client.web.********************.js |
994 B |
dotcom-rendering/dist/5047.client.web.********************.js |
779 B |
dotcom-rendering/dist/5053.client.web.********************.js |
526 B |
dotcom-rendering/dist/5116.client.web.********************.js |
1.85 kB |
dotcom-rendering/dist/5410.client.web.********************.js |
3.44 kB |
dotcom-rendering/dist/5561.client.web.********************.js |
3.42 kB |
dotcom-rendering/dist/5598.client.web.********************.js |
3.5 kB |
dotcom-rendering/dist/5619.client.web.********************.js |
926 B |
dotcom-rendering/dist/5643.client.web.********************.js |
2.98 kB |
dotcom-rendering/dist/5730.client.web.********************.js |
954 B |
dotcom-rendering/dist/5985.client.web.********************.js |
750 B |
dotcom-rendering/dist/6043.client.web.********************.js |
852 B |
dotcom-rendering/dist/6140.client.web.********************.js |
853 B |
dotcom-rendering/dist/6148.client.web.********************.js |
3.6 kB |
dotcom-rendering/dist/6271.client.web.********************.js |
5.87 kB |
dotcom-rendering/dist/6561.client.web.********************.js |
2.43 kB |
dotcom-rendering/dist/6651.client.web.********************.js |
904 B |
dotcom-rendering/dist/669.client.web.********************.js |
2.81 kB |
dotcom-rendering/dist/6693.client.web.********************.js |
822 B |
dotcom-rendering/dist/6853.client.web.********************.js |
1 kB |
dotcom-rendering/dist/6926.client.web.********************.js |
3.86 kB |
dotcom-rendering/dist/7005.client.web.********************.js |
3.34 kB |
dotcom-rendering/dist/7018.client.web.********************.js |
787 B |
dotcom-rendering/dist/7056.client.web.********************.js |
8.28 kB |
dotcom-rendering/dist/7163.client.web.********************.js |
3.28 kB |
dotcom-rendering/dist/7356.client.web.********************.js |
1 kB |
dotcom-rendering/dist/7589.client.web.********************.js |
2.95 kB |
dotcom-rendering/dist/7743.client.web.********************.js |
2.66 kB |
dotcom-rendering/dist/7810.client.web.********************.js |
4.79 kB |
dotcom-rendering/dist/7855.client.web.********************.js |
788 B |
dotcom-rendering/dist/7934.client.web.********************.js |
8.66 kB |
dotcom-rendering/dist/8002.client.web.********************.js |
801 B |
dotcom-rendering/dist/8193.client.web.********************.js |
8.7 kB |
dotcom-rendering/dist/8288.client.web.********************.js |
23 kB |
dotcom-rendering/dist/8355.client.web.********************.js |
41.7 kB |
dotcom-rendering/dist/841.client.web.********************.js |
789 B |
dotcom-rendering/dist/8500.client.web.********************.js |
3.81 kB |
dotcom-rendering/dist/8607.client.web.********************.js |
13.3 kB |
dotcom-rendering/dist/8762.client.web.********************.js |
2.68 kB |
dotcom-rendering/dist/8818.client.web.********************.js |
748 B |
dotcom-rendering/dist/8937.client.web.********************.js |
888 B |
dotcom-rendering/dist/9148.client.web.********************.js |
3.13 kB |
dotcom-rendering/dist/9173.client.web.********************.js |
723 B |
dotcom-rendering/dist/9309.client.web.********************.js |
618 B |
dotcom-rendering/dist/9314.client.web.********************.js |
822 B |
dotcom-rendering/dist/9523.client.web.********************.js |
3.74 kB |
dotcom-rendering/dist/954.client.web.********************.js |
431 B |
dotcom-rendering/dist/9584.client.web.********************.js |
1.56 kB |
dotcom-rendering/dist/9621.client.web.********************.js |
723 B |
dotcom-rendering/dist/9676.client.web.********************.js |
889 B |
dotcom-rendering/dist/9978.client.web.********************.js |
960 B |
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js |
3.75 kB |
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js |
423 B |
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js |
4.15 kB |
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js |
3.65 kB |
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js |
3.03 kB |
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js |
2.46 kB |
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js |
3.63 kB |
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js |
2.04 kB |
dotcom-rendering/dist/Branding-importable.client.web.********************.js |
2.64 kB |
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js |
36.9 kB |
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js |
1.91 kB |
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js |
6.78 kB |
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js |
5.78 kB |
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js |
4.84 kB |
dotcom-rendering/dist/Carousel-importable.client.web.********************.js |
5.57 kB |
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js |
5.66 kB |
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js |
540 B |
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js |
3.28 kB |
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js |
2.47 kB |
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js |
4.06 kB |
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js |
1.67 kB |
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js |
3.61 kB |
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js |
4.16 kB |
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js |
2.01 kB |
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js |
2.43 kB |
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js |
3.35 kB |
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js |
610 B |
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js |
839 B |
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js |
342 B |
dotcom-rendering/dist/frameworks.client.web.********************.js |
20.7 kB |
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js |
3.82 kB |
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js |
10.8 kB |
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js |
1.68 kB |
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js |
2.66 kB |
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js |
15 kB |
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js |
9.45 kB |
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js |
783 B |
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js |
12.3 kB |
dotcom-rendering/dist/index.client.web.********************.js |
47.6 kB |
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js |
3.69 kB |
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js |
855 B |
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js |
6.1 kB |
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js |
4.72 kB |
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js |
3.48 kB |
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js |
4.59 kB |
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js |
3.54 kB |
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js |
2.21 kB |
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js |
435 B |
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js |
6.46 kB |
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js |
3.65 kB |
dotcom-rendering/dist/Liveness-importable.client.web.********************.js |
4.95 kB |
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js |
6.63 kB |
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js |
5.69 kB |
dotcom-rendering/dist/Metrics-importable.client.web.********************.js |
2.3 kB |
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js |
4.04 kB |
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js |
6.74 kB |
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js |
4.44 kB |
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js |
4.05 kB |
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js |
3.65 kB |
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js |
543 B |
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js |
801 B |
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js |
749 B |
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js |
538 B |
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js |
469 B |
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js |
1.89 kB |
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js |
3.65 kB |
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js |
1.99 kB |
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js |
6.26 kB |
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js |
3.63 kB |
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js |
4.43 kB |
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js |
2.14 kB |
dotcom-rendering/dist/sentry.client.web.********************.js |
771 B |
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js |
3.8 kB |
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js |
487 B |
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js |
1.53 kB |
dotcom-rendering/dist/shimport.client.web.********************.js |
2.79 kB |
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js |
646 B |
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js |
5.71 kB |
dotcom-rendering/dist/SignInGateCustomizableText.client.web.********************.js |
957 B |
dotcom-rendering/dist/SignInGateMain.client.web.********************.js |
1.19 kB |
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js |
2.7 kB |
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js |
3.52 kB |
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js |
4.56 kB |
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js |
5.53 kB |
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js |
3.81 kB |
dotcom-rendering/dist/SubNav-importable.client.web.********************.js |
2.25 kB |
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js |
3.78 kB |
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js |
3.17 kB |
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js |
1.25 kB |
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js |
1.02 kB |
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js |
3.71 kB |
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js |
5.7 kB |
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js |
3.54 kB |
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js |
5.47 kB |
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js |
3.97 kB |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy build 32716 of Mobile::mobile-apps-rendering to CODE
All deployment options
From guardian/actions-riff-raff.
Deploy build 8657 of dotcom:rendering-all to CODE
All deployment options
From guardian/actions-riff-raff.