csnx icon indicating copy to clipboard operation
csnx copied to clipboard

handle csnx storybooks from central storybooks app

Open sndrs opened this issue 5 months ago • 2 comments

What are you changing?

  • all storybooks are built/managed by apps/storybooks
  • typescript imports of react explicitly point to "./node_modules/@types/react"
    • thanks to https://github.com/pnpm/pnpm/issues/7158#issuecomment-1783974123
  • reverts bump of @guardian/ packages peerdep on @types/react which was only there to get storybook working (no longer needed so we can avoid a major bump for consumers)

Why?

keeps the storybook env discreet from the package development environments, meaning we can run storybook in different versions of e.g. react than we develop in. this is a more realistic use of the library.

Co-authored-by: @oliverabrahams

sndrs avatar Sep 25 '24 15:09 sndrs