spdlog_setup icon indicating copy to clipboard operation
spdlog_setup copied to clipboard

Optionally use external spdlog library

Open swltr opened this issue 3 years ago • 3 comments

As mentioned in #7, it would be nice to allow external dependencies to be used. This helps e.g. if you already have spdlog as a dependency in your CMake build. With this small change, it is possible to turn off auto-detecting spdlog. Leaving the target_link_libraries(spdlog_setup ...) calls as they are, these then simply use an existing spdlog library. You need to add that library somewhere else in your build, then. In my case, I have a line like

add_subdirectory(libs/cmake/spdlog-1.3.1)

in my top-level CMakeLists.txt.

swltr avatar Jan 05 '21 12:01 swltr

Codecov Report

Merging #72 (7d0a773) into master (91ecd72) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files           4        4           
  Lines         566      566           
=======================================
  Hits          499      499           
  Misses         67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91ecd72...7d0a773. Read the comment docs.

codecov[bot] avatar Jan 05 '21 12:01 codecov[bot]

@guangie88 What do you think about this?

swltr avatar Jan 05 '21 13:01 swltr

@guangie88 Any thoughts on this?

swltr avatar Mar 02 '21 08:03 swltr