guac icon indicating copy to clipboard operation
guac copied to clipboard

Handle situations where parsers create GuacNodes without the required identifier fields

Open lumjjb opened this issue 3 years ago • 0 comments

As with https://github.com/guacsec/guac/issues/236, we saw a bug where a parser was allowed to create a GuacNode/Edge without filling up an identifier.

lumjjb avatar Nov 18 '22 02:11 lumjjb

Codecov Report

Merging #17838 (2bcc78a) into main (a826720) will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17838      +/-   ##
==========================================
- Coverage   66.45%   66.43%   -0.02%     
==========================================
  Files        1012     1012              
  Lines      108433   108433              
  Branches     2677     2677              
==========================================
- Hits        72058    72040      -18     
- Misses      32429    32447      +18     
  Partials     3946     3946              
Flag Coverage Δ
unittests 66.43% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/auditlog/auditlog.go 14.28% <0.00%> (-46.43%) :arrow_down:
src/controller/event/topic.go 2.11% <0.00%> (-6.34%) :arrow_down:
src/jobservice/logger/sweeper/file_sweeper.go 56.25% <0.00%> (-6.25%) :arrow_down:
src/jobservice/sync/schedule.go 54.54% <0.00%> (+1.58%) :arrow_up:
...dashboard/schedule-card/schedule-card.component.ts 48.57% <0.00%> (+2.85%) :arrow_up:

codecov[bot] avatar Nov 22 '22 15:11 codecov[bot]