guac icon indicating copy to clipboard operation
guac copied to clipboard

Parser tests should check for calls to GetIdentities too

Open lumjjb opened this issue 2 years ago • 7 comments

Currently parser tests do not test for GetIdentities (in pkg/ingestor/parser)

lumjjb avatar Oct 07 '22 22:10 lumjjb

I would be interested to work on this, if no one else has started working on it. cc @lumjjb

ankitm123 avatar Oct 27 '22 15:10 ankitm123

Sorry missed this message but yes @ankitm123 you can work on this. Thanks!

pxp928 avatar Dec 06 '22 13:12 pxp928

Hi @ankitm123 ! are you still looking into this issue?

lumjjb avatar Feb 07 '23 15:02 lumjjb

Is this issue resolved by adding this or we want to incorporate additional testing?

stevemenezes avatar Jun 30 '23 02:06 stevemenezes

Hello @stevemenezes, the thought process here was to get unit tests for each implementation (for example SPDX) https://github.com/guacsec/guac/blob/d29cbb83a14eeeef5daa108f8b7d6779c4c85086/pkg/ingestor/parser/spdx/parse_spdx.go#L313-L315

Currently, we are not using, GetIdentities but is high on the priority list to get started.

pxp928 avatar Jun 30 '23 11:06 pxp928

Hi @lumjjb @pxp928! I'd like to work on this.

rakshitgondwal avatar Apr 29 '24 07:04 rakshitgondwal

GetIdentities is still not implemented yet. So nothing to be done at this point.

pxp928 avatar Apr 29 '24 21:04 pxp928