angular-flash icon indicating copy to clipboard operation
angular-flash copied to clipboard

Published 20 hours ago • verified publisher icon gtramontina

Add optional timeout

Open Traxmaxx opened this issue 11 years ago • 5 comments

Added an optional timeout value so that current implementations will not break. Any idea how to test this properly?

Traxmaxx avatar Nov 15 '13 16:11 Traxmaxx

Hey there, Just to give you an update on this PR... I'm working a bit more on it as the flash function can be used with a single parameter (flash('Done!')) and supporting flash('Done!', 2000) would be desired as well...

I'm also looking into using angular's $timeout.flush() for testing...

gtramontina avatar Nov 20 '13 01:11 gtramontina

Good stuff! Let me know if you need anything.

Traxmaxx avatar Nov 20 '13 08:11 Traxmaxx

Heya, any update on the flash timeout?

Traxmaxx avatar Jan 28 '14 09:01 Traxmaxx

Hey! Sorry about that! I actually got the single and multiple parameters working but was facing some problems with the $timeout.flush() when testing... Then I got swamped with work and end up not coming back to it. I'll try to push something up tonight (PST)!

gtramontina avatar Jan 29 '14 17:01 gtramontina

No worries, take your time : )

Traxmaxx avatar Jan 29 '14 19:01 Traxmaxx