Gunnar Mills

Should use Inventory Item "PrettyName"

3

We should map "PrettyName" to Redfish Name. https://github.com/openbmc/phosphor-dbus-interfaces/blob/495981805244269650bee13d1ee8f13543b2bc5a/xyz/openbmc_project/Inventory/Item.interface.yaml#L5 Drives, Processors, etc, etc. all need to be moved.

Redfish: Manager: OEM: Fix warnings around odata.id not matching

3

``` complex @odata.id: Expected @odata.id to match URI link /redfish/v1/Managers/bmc#/Oem/OpenBmc complex @odata.id: Expected @odata.id to match URI link /redfish/v1/Managers/bmc#/Oem ```

Validator: Warning: Oem.OpenBmc.Certificates not defined in schema OemManager

4

From the validator: WARNING - Oem.OpenBmc.Certificates not defined in schema OemManager (check version, spelling and casing) https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/managers.hpp#L1627 ``` "Oem": { "@odata.context": "/redfish/v1/$metadata#OemManager.Oem", "@odata.id": "/redfish/v1/Managers/bmc#/Oem", "@odata.type": "#OemManager.Oem", "OpenBmc": { "@odata.context": "/redfish/v1/$metadata#OemManager.OpenBmc",...

Redfish: Violations: /redfish/v1/Managers/bmc/Truststore/Certificates

9

1. A certificate collection can only be implemented at these paths: https://redfish.dmtf.org/schemas/v1/CertificateCollection_v1.xml The options under Managers are: /redfish/v1/Managers/{ManagerId}/RemoteAccountService/Accounts/{ManagerAccountId}/Certificates /redfish/v1/Managers/{ManagerId}/RemoteAccountService/ActiveDirectory/Certificates /redfish/v1/Managers/{ManagerId}/RemoteAccountService/LDAP/Certificates /redfish/v1/Managers/{ManagerId}/RemoteAccountService/ExternalAccountProviders/{ExternalAccountProviderId}/Certificates /redfish/v1/Managers/{ManagerId}/NetworkProtocol/HTTPS/Certificates 2. If /redfish/v1/Managers/bmc/Truststore/Certificates is a path; /redfish/v1/Managers/bmc/Truststore should...

Why not contribute the patches to the Linux Foundation OpenBMC project?

3

In just bmcweb, I see 80+ patches. Why not contribute those upstream to the LF OpenBMC Project? https://github.com/opencomputeproject/MegaRAC-OpenEdition/tree/master/meta-ami/recipes-phosphor/rest/bmcweb

Move away from Event subscription protocol

3

I still see the Event subscription protocol used here: https://github.com/openbmc/webui-vue/blob/780733a1b426a927140619857d732fb472d5cf38/src/store/plugins/WebSocketPlugin.js#L25 See below for more information on the Event subscription protocol: https://github.com/openbmc/docs/blob/224266ecfd528544e9f5473cc4607d9b6b7c435f/rest-api.md#event-subscription-protocol The Event subscription protocol is behind the rest meson...

SNMP page

5

We had an SNMP panel on phosphor-webui. Need the SNMP Redfish API first. SNMP was added to Redfish in 2019.4 just need to implement it in bmcweb. https://github.com/openbmc/phosphor-webui/commit/ff64c54a93aaf1ffb4df4b2d4c16c392d869f533 was the...

Move away from /subscribe websocket

3

https://github.com/openbmc/webui-vue/blob/6b0e3a71cb691d24e5153cd4d4ec10e174ae4398/src/store/plugins/WebSocketPlugin.js#L27 Could move to just normal polling or Redfish events https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/29344 turns the default of REST D-Bus to OFF. To make the webui-vue GUI work with this default setting would...

Move TPMEnable to Redfish

5

TPMEnable is the only xyz/openbmc_project/ interface I see being called in webui-vue. https://github.com/openbmc/webui-vue/blob/5c977976d9450b50faeb33ba5bd1b5deaabcc3b5/src/store/modules/Control/BootSettingsStore.js#L76 TPMEnable is being upstreamed to Redfish now, should be in Redfish's 2020.4 release.

Remote logging

5

Had remote logging in phosphor-webui. https://github.com/openbmc/phosphor-webui/commit/e4194ce0dc8a941c4f30fd0995f9ba4c13cec560 Need a remote logging Redfish API first though.