qrcode-terminal icon indicating copy to clipboard operation
qrcode-terminal copied to clipboard

use hex escapes instead of octal to satisfy overzealous linters

Open stevvvn opened this issue 6 years ago • 4 comments

I ran into this issue trying to bundle an app with nexe:

Acorn error: Octal literal in strict mode (3:13)
File: /home/git/hub-service-node/node_modules/qrcode-terminal/lib/main.js

1 var QRCode = require('./../vendor/QRCode'),
2 QRErrorCorrectLevel = require('./../vendor/QRCode/QRErrorCorrectLevel'),
3 black = "\033[40m \033[0m",

I think the diagnostic is wrong as this code shouldn't be evaluated by strict standards, but oct->hex seems like an easy enough compromise to convince it to include the file in the bundle.

stevvvn avatar Jul 10 '18 19:07 stevvvn

CI failure seems out of my control

stevvvn avatar Jul 10 '18 19:07 stevvvn

This is a necessary update! Thank you!

ramphy avatar Jun 01 '23 00:06 ramphy

@gtanner Can we get this resolved?

AlexV525 avatar Oct 11 '23 02:10 AlexV525

@mwbrooks @gtanner please merge and release this fix. We have issues using qrcode-terminal with Next.js 14 because of this. 🙏

chybisov avatar Dec 08 '23 14:12 chybisov