qrcode-terminal
qrcode-terminal copied to clipboard
use hex escapes instead of octal to satisfy overzealous linters
I ran into this issue trying to bundle an app with nexe
:
Acorn error: Octal literal in strict mode (3:13)
File: /home/git/hub-service-node/node_modules/qrcode-terminal/lib/main.js1 var QRCode = require('./../vendor/QRCode'),
2 QRErrorCorrectLevel = require('./../vendor/QRCode/QRErrorCorrectLevel'),
3 black = "\033[40m \033[0m",
I think the diagnostic is wrong as this code shouldn't be evaluated by strict standards, but oct->hex seems like an easy enough compromise to convince it to include the file in the bundle.
CI failure seems out of my control
This is a necessary update! Thank you!
@gtanner Can we get this resolved?
@mwbrooks @gtanner please merge and release this fix. We have issues using qrcode-terminal with Next.js 14 because of this. 🙏