Trilogy-ASI-Script icon indicating copy to clipboard operation
Trilogy-ASI-Script copied to clipboard

"Health, Money & Armor" Cheat not setting armor to max armor the player has unlocked

Open Frouk3 opened this issue 3 years ago • 9 comments

https://github.com/gta-chaos-mod/Trilogy-ASI-Script/blob/ff32ec055d6032aa80c5aba0d491383f55bfe32c/src/gtasa/effects/cheats/player/HealthArmorMoneyCheat.cpp#L21 This mistake is a huge, in original cheat it accessing max armor in player data (0xB7CD98+0x150)

Frouk3 avatar Mar 13 '22 11:03 Frouk3

Why exactly are you making an issue with a title that doesn't even try to talk about what issue this is?

Anyway: Seems like an easy fix. CPlayerInfo.h#86 has a variable for the max armor so it's as simple as putting that in instead of 100.0f.

Will be fixing that once I will pick up development on the mod again (sometime in the near future probably)

Lordmau5 avatar Mar 26 '22 22:03 Lordmau5

Why exactly are you making an issue with a title that doesn't even try to talk about what issue this is?

Anyway: Seems like an easy fix. CPlayerInfo.h#86 has a variable for the max armor so it's as simple as putting that in instead of 100.0f.

Will be fixing that once I will pick up development on the mod again (sometime in the near future probably)

I can do pull request so you can just merge

Frouk3 avatar Mar 27 '22 05:03 Frouk3

And ye i haven't enough time to think about title

Frouk3 avatar Mar 27 '22 05:03 Frouk3

Got it fixed in-dev :)

Can't say when a new version will come out but it will be fixed with the new version (which hopefully has more fixes and some new effects, too)

Lordmau5 avatar Mar 29 '22 17:03 Lordmau5

Well that's great :D

Frouk3 avatar Mar 29 '22 17:03 Frouk3

Nah, please keep this open so I can close it when it is actually fixed 😂 Better for me to keep track of things

Lordmau5 avatar Mar 29 '22 17:03 Lordmau5

ok

Frouk3 avatar Mar 31 '22 05:03 Frouk3

And one more thing that player using Cheat Engine can set max armor until the limit(255)

Frouk3 avatar Apr 06 '22 06:04 Frouk3

As long as the value in CPlayerInfo is being updated it should work.

I will not go out of my way to support someone using Cheat Engine to alter it - not because I want people to not cheat, but because it's something that's out of my control if they aren't doing it the right way

Lordmau5 avatar Apr 06 '22 10:04 Lordmau5

Fixed in v3.0.1

Lordmau5 avatar Sep 03 '22 09:09 Lordmau5