Scott Rohde

Results 82 comments of Scott Rohde

All constraints except the `outdir` constraint are live. To do: Incorporate constraints from `miscellaneous_constraints` branch into new batch of constraints.

Thinking about this again, the bulk upload code assumes that for any citation, the value of `treatments.name` will be unique across all treatments associated with the citation via the `citations_treatments`...

@dlebauer You said the other day to make `raw` default to false. Looking back over these comments, I see that I fixed violations of `raw NOT NULL` constraint by changing...

The same constraint has been added twice in two different migrations: `ADD CONSTRAINT unique_names_per_modeltype UNIQUE(name, modeltype_id)` `ADD CONSTRAINT unique_name_per_model UNIQUE (name, modeltype_id)` One of these (the latter) should be removed.

Still need to deal with duplicate constraint mentioned in previous comment.

To do: - add uniqueness contraints on apikey and email - maybe require salt to be non-null There are only two rows in ebi_production where salt is null (names Carl...

@dlebauer Are we dispensing with this constraint: ``` sql ALTER TABLE dbfiles ADD UNIQUE (container_type, container_id); ``` As I mentioned, there are _many_ violations.

@dlebauer Is there ever a case where the same file will be referenced more than one in this table, such as the same file stored in two different locations? If...

The first column set mentioned -- (file_name, file_path, machine_id) -- should be unique. Unless perhaps a given file can be associated with multiple containers.

What does it mean for file_name to be blank or NULL? There currently is only one case of this.