ngStorage icon indicating copy to clipboard operation
ngStorage copied to clipboard

Add $ngStorageChanged event after apply with changes

Open schmuli opened this issue 8 years ago • 4 comments

If we detect changes during the apply phase, we broadcast a $ngStorageChanged event on the $rootScope.

Additionally, since we also detect any changes to the underlying storage and apply those in the same manner, this event will be broadcast when the change might have come from a different tab.

Fixes #214

schmuli avatar Aug 18 '16 00:08 schmuli

Sorry about the formatting in the test, my VI isn't setup correctly for JS.

Also, currently I only implemented one event which will be fired for both storage services, local and session. It should be trivial to add an indicator as part of the event data from which service the event was broadcast.

schmuli avatar Aug 18 '16 00:08 schmuli

any update on this?

dr3am3r avatar Aug 25 '16 10:08 dr3am3r

Seems like a good addition. Will merge.

egilkh avatar Aug 25 '16 10:08 egilkh

@egilkh Any chance of getting this merged any time soon?

Thanks.

schmuli avatar Oct 27 '16 12:10 schmuli