regexr
regexr copied to clipboard
gskinner
please add optional dark theme
v3.0 has a styling model that might make this easy. It likely won't be supported in v3.0, but I'm leaving the door open to support it in the not too distant future.
I'm posting here to avoid opening a new issue.
The picture below shows how the default input text area background on https://regexr.com/ are looking. Are you really thing that it's useful since the text color also is black?
I haven't seen that one before. What browser is this in? Do you have any extensions that could be causing it?
Sent from my mobile, please excuse typos & brevity.
On Nov 19, 2017, at 12:22 AM, cranes-bill [email protected] wrote:
I'm posting here to avoid opening a new issue. The picture below shows how the default input text area background on https://regexr.com/ are looking. Are you really thing that it's useful since the text color also is black?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
@gskinner The browser is QupZilla. It's a QtWebEngine browser. I used the website about 2-3 months ago for the last time and the issue was not existing. Does something was changed in the style-sheet in this period?
I don't think there have been any updates to the live site in the last few months (we've been working on a new version). Perhaps a browser update caused it?
Sent from my mobile, please excuse typos & brevity.
On Nov 19, 2017, at 12:15 PM, cranes-bill [email protected] wrote:
@gskinner The browser is QupZilla. It's a QtWebEngine browser. I used the website about 2-3 months ago for the last time and the issue was not existing. Does something was changed in the style-sheet in this period?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Any thoughts on where you would expect to see this option surfaced in the UI?
@gskinner I'm not exactly sure what you mean... if you mean where would a "toggle" button be located to turn on/off the dark theme, I'd say that the Menu on the left is a good place to put it. However, if you mean what parts of the UI should be darkened, I'd say that the Expression, Text, and Tools windows would be good places to start. Most everything else is already dark, so those are really the only areas that need work.
Is this implemented? It looks it was targeted for a 3.1 release but I'm not finding the option to enable it anywhere currently...
I just wrote a dark theme userstyle for Regexr (compatible with Stylus): https://github.com/Calinou/regexr-dark
A built-in dark theme switch would be ideal, but this can do for now :slightly_smiling_face:
@Calinou Hey, that looks pretty good! Thanks for sharing it. Maybe it could be incorporated into the main repository, too, at some point.
@Calinou - would love to take a look, but I don't use Stylus. Mind adding a screenshot to your README?
As a brief update: this functionality still has not been added, but it is on my list.
Quick update, this feature is almost complete. Just adding in functionality to retain your preference (initially in a cookie, eventually on your account as well).
@gskinner I assume you're using @Calinou's code for the dark theme, so will we need to disable his userstyle for the new builtin theme to function correctly?
This was implemented by https://github.com/gskinner/regexr/commit/f7bb3e359608e15648b28f22f031c0b0c58c0b9f. This issue can now be closed :slightly_smiling_face: