kinoko
kinoko copied to clipboard
gsioteam
Questions and suggestions
Questions
- Can plug-ins be unloaded/removed?
- Are book.js, chapter.js, collection.js, config.json, index.js and search.js minimal requirements for a plug-in? (Looking through a few plug-ins, they appear to be required.)
Suggestions
- Documentation for plug-in creation or sample/template plug-ins. (Link to sample/template or documentation linked in readme would be useful.)
- Ability to open Favorites on start. (The way Manga Home works with main project.)
- Ability to uninstall plug-ins. (If it's not currently possible.)
I am sorry for late replaying, I manage to write a plugin document. And the other suggestions are very good I will improve the application.
Considering to use json for configs, you could host a plugin any where, the code also dont need to include git library, one [host plugin] could hosting as any plugins as you want. You could add as many [host plugin] as you want, every [host plugin] contains many plugins
Ex: https://mydomain.com/myplugins/all.json https://yourdomain.com/yourplugins/all.json
The app will add [host plugin], parse all.json to find out all plugins of the [host plugin].
The folder structure at the root of [host plugin]:
all.json // will declare all plugins of the host: name, path to config.json file of each plugin. ./mangaone ..config.json ..plugin.zip // the zip of ./src folder, plugin author must zip the src folder and declare in config.json ../src ....index.js ....search.js ....detail.js ./mangatwo ..config.json ..plugin.zip // the zip of ./src folder, plugin author must zip the src folder and declare in config.json ../src ....index.js ....search.js ....detail.js
User will add host plugin, the app will pull the all plugins of the host plugin to a list, user will chose each plugin they want to install, the app will download plugin.zip of the selected plugin and extract to local. Each plugin has a config.json, define current version, the app will schedule update the config to check if have different version and alert user to update.
@Zehra I have write a plug-in document. I don’t know if it explains clearly how the plugin works, so be free to ask questions.
And in the last version (v2.0.4), the default plug-in could be removed now.
- Open Favorites on start About this feature could modify many UI, and I think there are several bugs in favorites page I will consider this, but add it immediately.
@winterdl I can't say that this feature will be implemented. Because I think git is open and normally for a developer, maybe it is geeky, but this is a geeky project. I have another resolution, I use a github issue as my default plug-in list. This list is signed by a private key which is owned by me, that means I am the only one can edit this list. I think maybe anybody could generate an issue like my default plug-in list, with the public key at the begin of issue, and this list could be imported.
@gsioteam Apologies for the late reply. The plug-in docs looks pretty good overall and everything seems mostly straightforward to understand.
My only questions would be on how is image handling done for chapters and if images as binary blobs are supported.
@gsioteam Apologies for the late reply. The plug-in docs looks pretty good overall and everything seems mostly straightforward to understand.
My only questions would be on how is image handling done for chapters and if images as binary blobs are supported.
Images as binary blobs is not supported. Just send the url and headers of image request to application. I know sometime we will decrypt or special decode the image, this is actually required . If you give me an application scenario, I will research how to implement it。
