battery_model
battery_model copied to clipboard
Potentially incorrect operator in the Positive_charge Function
Background The positive_charge function in the read battery_model.py file appears to constrain Eout when the S < Rmax.
Current Behavior Currently the battery is exporting more power than it can hold. for example; When S = 100, RMax = 250 and eta = 0.90, Eout currently equals 105
Expected Behavior the desired output should be as follows; When S = 100, RMax = 250 and eta = 0.90, Eout should equal 95
Possible Solution In the positive_charge function switch the operator from divide to multiply