battery_model icon indicating copy to clipboard operation
battery_model copied to clipboard

Potentially incorrect operator in the Positive_charge Function

Open heyerbobby opened this issue 4 years ago • 1 comments

Background The positive_charge function in the read battery_model.py file appears to constrain Eout when the S < Rmax.

Current Behavior Currently the battery is exporting more power than it can hold. for example; When S = 100, RMax = 250 and eta = 0.90, Eout currently equals 105

Expected Behavior the desired output should be as follows; When S = 100, RMax = 250 and eta = 0.90, Eout should equal 95

Possible Solution In the positive_charge function switch the operator from divide to multiply

heyerbobby avatar Sep 01 '20 02:09 heyerbobby

Thanks. This is an old project but I’ll take a look to confirm and fix.

Sent with GitHawk

gschivley avatar Sep 02 '20 12:09 gschivley