Yorgos Saslis

Results 61 comments of Yorgos Saslis

@ddhuy thanks for that. This seems like a weird case, because I would expect since we are also running a MySQL > 5.7.5 to be also running into this. I...

Thanks for confirming @peteroyle! @leftyb can you confirm about this? it sounds like a valid issue / suggestion to fix.

@jaimecasero i agree. this is what i tried to highlight on my opening PR comment above. how would you propose we handle the wildfly10 stuff then? Should I just delete...

@jaimecasero ah, i see, so you're saying i should reverse commit this: https://github.com/RestComm/Restcomm-Connect/pull/2937/commits/a4df2e09a6fc5236ec4b53f111615f23de0dfdc3 ?

@jaimecasero reverse committed with https://github.com/RestComm/Restcomm-Connect/pull/2937/commits/fe1e250f223686ce3d0d56f1fab3c524e489c4e7

@ddhuy thanks for the new PR. This is much clearer. with regards to your particular question, I will say the same thing I had replied back then: https://github.com/RestComm/Restcomm-Connect/issues/2497#issuecomment-347610760 Plz do...

Thanks @ddhuy and apologies for the delayed response here. Will request review from core team.

@zahidMed / @deruelle doing some internal housekeeping here... is this still a valid PR ?

Hey @croufay! doing some housekeeping here... is this still a valid PR ?

@ddhuy the problem with commit https://github.com/RestComm/Restcomm-Connect/pull/2641/commits/b001a77c8ea7f9d1757315dd5affb2e5d52b157c is that you've changed the type of the `InvalidEmailException`: used to be `Exception`, now it's `RuntimeException`. This means that its usages (e.g. https://github.com/RestComm/Restcomm-Connect/blob/e449462909d5620daa873e9d20818fba6413ac5c/restcomm/restcomm.http/src/main/java/org/restcomm/connect/http/EmailMessagesEndpoint.java#L91 )...