markor icon indicating copy to clipboard operation
markor copied to clipboard

Feature: Save as New File

Open ChiefMikeK opened this issue 4 years ago • 11 comments

General information

  • App version: v101-2.2.1 from github
  • System: Android 6.0.1 Samsung

Description

Sometimes I need to save a new Quicknote{¿date?}.md vice appending the older/current Quicknote.md but there's no easy way to accomplish that.
So suggest you add an entry to the menu-pull-down as in screenshot:
● Save As (newfile) & also for translations be shure to distinguish it from
● Save (overwrite)

Screenshot

Markor-SaveAs

ChiefMikeK avatar Nov 01 '19 20:11 ChiefMikeK

Hi! Can I work on this issue? Is it still open @gsantner ? Thanks

jakub231 avatar Nov 04 '19 12:11 jakub231

@jakub231 Yes not done yet, thanks

gsantner avatar Nov 04 '19 13:11 gsantner

Hi @gsantner I've added the menu item but I'm not sure how to approach implementing save as UI. How do you want this to be implemented?

2019-11-17_15-05

gokomer avatar Nov 17 '19 12:11 gokomer

2019-11-17_15-05

fwiw

In some languages the word "as" doesn't translate well that is why I had recommended including (overwrite) & (newfile) in the dropdown 👀
:neckbeard:

ChiefMikeK avatar Nov 17 '19 13:11 ChiefMikeK

Markor_github

Still Hoping to 👀 this!

🔜¯\\_(ツ)_/¯ :neckbeard:

ChiefMikeK avatar Feb 22 '21 03:02 ChiefMikeK

Hi, I think I have understood how to add the UI, and I found the DocumentEditFragment class to read. However I don't know what is the way to open a dialog and ask the user for new location(directory, and ask for a new name as well), is there a java class in this project that I should read? BTW, after a save as action, the word/notepad/typora would like to open the new copied file to edit in the same activity, so after the action, I think I should invoke the loadDocument() method in DocumentEditFragment class, did I got it right?

2catycm avatar May 14 '22 16:05 2catycm

newfile and rename dialog java classes.

gsantner avatar May 14 '22 18:05 gsantner

thanks for assigning, I will try my best to finish the issue. 

---Original--- From: "Gregor @.> Date: Mon, May 16, 2022 02:03 AM To: @.>; Cc: @.@.>; Subject: Re: [gsantner/markor] Feature: Save as New File (#760)

Assigned #760 to @2catycm.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>

2catycm avatar May 18 '22 10:05 2catycm

keep in mind, its not your job. assignment is just a note who MAY do what.

gsantner avatar May 18 '22 13:05 gsantner

OK

---Original--- From: "Gregor @.> Date: Wed, May 18, 2022 21:53 PM To: @.>; Cc: @.@.>; Subject: Re: [gsantner/markor] Feature: Save as New File (#760)

keep in mind, its not your job. assignment is just a note who MAY do what.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

2catycm avatar May 18 '22 15:05 2catycm

Here's an possible PR that may solve this issue.

2catycm avatar May 18 '22 15:05 2catycm

there is now a button "Markor" when you select text, and you can select also all text. Using that button leads to the Share-Into screen where you can "Save as new file", or append to, or whatever you like to.

If you want to make safety copies, make it before changing up your text, or use some sync software functionalties (which i.e. do backup/history on server side). Trusting on editor undo or alike is not what you should look out to, whats gone is gone and when you turn off the screen Markor will save, as it should.

gsantner avatar Aug 21 '22 22:08 gsantner