markor icon indicating copy to clipboard operation
markor copied to clipboard

Make headline dialog work in view mode

Open guanglinn opened this issue 1 year ago • 5 comments

I made the headline dialog work in view mode. This feature could meet the requirements in the suggestions from PR #2190.

guanglinn avatar Jan 19 '24 07:01 guanglinn

https://github.com/gsantner/markor/assets/60415467/a36fd51e-500b-4fc3-be2e-c9f0bbbf774f

guanglinn avatar Jan 19 '24 07:01 guanglinn

Nice. How do you have rounded dialog corners though?

harshad1 avatar Jan 21 '24 21:01 harshad1

Nice. How do you have rounded dialog corners though?

This is my old device which was flashed a custom ROM crDroid, I guess this ROM modified the style of the dialog. Anyway, it does look much better.

guanglinn avatar Jan 22 '24 06:01 guanglinn

conflicts

gsantner avatar Feb 16 '24 04:02 gsantner

@gsantner . Conflicts has been resolved, it is ready to be merged now.

guanglinn avatar Feb 16 '24 13:02 guanglinn

Had been looking forward to this moment for a long time! 😄

guanglinn avatar Mar 27 '24 02:03 guanglinn

Thanks for help, and your patience

gsantner avatar Mar 27 '24 03:03 gsantner