markor icon indicating copy to clipboard operation
markor copied to clipboard

FileBrowser: File Modification Time not updated until app restart

Open XYIheng opened this issue 1 year ago • 4 comments

⚠️ This issue respects the following points: ⚠️

  • [X] This is a bug. Not a question or feature request.
  • [X] The topic is not already reported at Issues. (I've searched it).
  • [X] Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • [X] The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Modifying a file does not update its modification time immediately. Refresh file list also not work.
The file's modification time remains unchanged until the application is restarted.

Steps to reproduce

  1. open an existing file
  2. edit it
  3. close
  4. see the error: file modification time does not change

https://github.com/gsantner/markor/assets/31406320/1ba0560b-759a-4b54-9948-420c21b23023

Information

Android version: 8 Device: pixel2 App Version: 2.11.1

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-

XYIheng avatar Jan 03 '24 16:01 XYIheng

@XYIheng Can you try a APK you can find on any of the development builds here https://github.com/gsantner/markor/actions? As the file metadata caching was reworked this should not be case in the master branch anymore.

gsantner avatar Jan 11 '24 18:01 gsantner

@gsantner Hi, it still does not work for me. I try the apk here https://github.com/gsantner/markor/actions/runs/7493416005. The file's modification time remains unchanged until the application is restarted.

XYIheng avatar Jan 18 '24 15:01 XYIheng

@gsantner We should call notifyItemChanged(position) or notifyDataSetChanged() after some files were modified.

guanglinn avatar Apr 09 '24 01:04 guanglinn

On pull down reload we also do that as far I know. But the info might be cached somewhere

gsantner avatar Apr 20 '24 05:04 gsantner