markor icon indicating copy to clipboard operation
markor copied to clipboard

per-file-settings: encryption password

Open redstreet opened this issue 3 years ago • 11 comments

Encryption is an awesome start, thank you @opensource21 and @gsantner for getting this in. For me, this was a critical feature.

The existing feature addresses the data at rest encryption. This feature request is to make "locking" easy. This allows one to let someone else use their phone for a few minutes, unsupervised, without fear that private notes can be read. This can be accomplished in one or more of these ways:

  • by having Markor forget the password on a configurable timeout (eg: after 5mins)
  • by having Markor forget the password when exiting the app
  • by placing a "forget" button on the main app screen

Is one or more of the above an easy feature to implement? Happy to hash this out further, provide examples of other open source apps that do this, etc. Thanks much for considering!

May I also take a moment to say how awesome Markor is. It's exactly what I was looking for. Thank you for building, sharing, and maintaining it @gsantner!

redstreet avatar Feb 22 '21 12:02 redstreet

I think there are very simple solutions:

  • Use the app protection from android to disable access to Markor
  • Simply set the password to 123456 instead of delete the password.

opensource21 avatar Feb 26 '21 07:02 opensource21

Of course, those are simple solutions....and also extremely inconvenient to the point of being unusable if done 20 times a day. I already tried :).

Automation (the ideas I suggested above) removes the friction and increases security. These methods are pretty standard in most apps that deal with security, hence the request. If it's not trivial to implement any of them, I understand. I was hoping "forget while exiting" would be the easiest and most trivial option to implement.

redstreet avatar Feb 26 '21 10:02 redstreet

I do say clearing / setting random password / whatever value is a easy option.
So a password input dialog triggers.

Plus some settings option, always ask for password when restarting the app (=onCreate at MainActivity). On top of that, have a delay of ~5 minutes for the restart check, so if you recently worked with Markor you don't have to re-type everytime you want to add a additional line of text.

gsantner avatar Feb 27 '21 10:02 gsantner

I am using markor since last week. It is a great app. Only thing I miss is the password protection. Entire app password protection will create inconvenience. So per file password is indeed desirable.

sk-Prime avatar Aug 13 '21 04:08 sk-Prime

This issue is about consuming passwords "per-file", encryption itself is already there.

You can enable it in settings. One password for all.

gsantner avatar Aug 13 '21 09:08 gsantner

Yes there is an option for that, for example test.md.jenc is an encrypted file, anyone can open it from Markor, isn't it? So if anyone (e.g family members/kid) take my phone and they can see it. Am I missing something? I thought that requiring a password to open encrypted file will be a good feature.

sk-Prime avatar Aug 13 '21 15:08 sk-Prime

what you seemingly look for is more, locking Markor so you cannot use it without password.

gsantner avatar Aug 13 '21 15:08 gsantner

Yes, you are right but not locking entire markor. Ask password only for encrypted file. e.g. test.md.jenc is an encrypted file. So if i try to open it, there will be a popup dialog box which will ask for decrypt password. If i can not input correct password it will say password mismatch, otherwise open the file.

sk-Prime avatar Aug 13 '21 15:08 sk-Prime

Markor is now one of my favorite, thank you ! I would love to have this per-file encryption password as described by sk-Prime. To me it's a must have.

phil834a avatar Mar 04 '23 21:03 phil834a

@opensource21 Love markor and its simplicity, thanks! Sorry about the irrelevancy but, i'm an idiot and changed the password so now i don't have access to my files. Is it possible to fix that? I changed x20+ times the password with no luck, if that makes it worse

st3ss avatar Mar 10 '24 23:03 st3ss

If you forgot the old password the content is lost. That's the price for good encryption.

opensource21 avatar Mar 11 '24 05:03 opensource21