dandelion icon indicating copy to clipboard operation
dandelion copied to clipboard

BuildConfig: improve build reproducibility: port language-sort fix from markor

Open jayaddison opened this issue 9 months ago • 3 comments

Cherry-picks two small fixes from markor, in order to improve build reproducibility of dandelion (part 1-of-2 to resolve #300).

During conflict resolution, I checked that the language codes added by the cherry-picked commit were already supported in dandelion (by checking for relevant app/src/main/res/values-{locale} directories).

jayaddison avatar May 20 '25 11:05 jayaddison

Hello, thank you for improvements.

dandelion is not active developed for a long while (not sure if login and features even all still work as they did back then), hence also not updated otherwise. Thanks for updating general, but even with the changes merged, I don't plan to release a new update. Unless there is actual improvements/fixes/features for the app functionalities.

As you noticed, yes this project has a lot of common - many of my open source projects share functionality, setup & utility. But only Markor has moved on in the last years.

gsantner avatar May 20 '25 19:05 gsantner

Ok, thank you @gsantner for the explanation, and my apologies for the noise of multiple PRs/issues as I explored this.

I will leave this open and be optimistic that some maintenance/development energy will arrive in this repository in future :)

If it's OK with you, I would like to file one issue for the remaining SOURCE_DATE_EPOCH suggestion in Markor - that half of #300 is valid as a possible improvemet there, I think.

jayaddison avatar May 20 '25 20:05 jayaddison

Feel free to make further improvements, ideally in one merge request together

As said - would be OK to merge for me, just don't think about making a release with no actual user viable changes.

gsantner avatar May 20 '25 21:05 gsantner

Closing; if you do change your mind and decide upon a future release, please feel free to add these changes - no problem if not, though.

jayaddison avatar Nov 09 '25 11:11 jayaddison