Jonathan Grynspan

Results 522 comments of Jonathan Grynspan

Tracked internally as rdar://129677014.

We need to continue to build with the Swift 6.2 toolchain on other platforms. Do we need to preserve that functionality for Android given there is no _official_ Android 6.2...

> It would not link there, since it was an executable and libc.so at API 28 didn't have backtrace(), so I couldn't run the tests that way. Does this mean...

> Not sure what you mean, is that because trunk in this repo is currently auto-merged to release/6.2? If so, we could also check `#if compiler(>=6.3)` to make sure this...

> I don't know whether it should work differently for executables or not, was just presenting my hypothesis, as most won't use executables for testing their apps anyway. However, I'll...

When you tried to run on API 28, had you set a minimum deployment target at compile time? Do we have a mechanism for doing so when building for Android?...

@finagolfin I'm approving now because obviously the code is shaped the way we want. Please don't merge it until we know for certain that the Android build will pass and...

Would it make sense to factor the new code into a dedicated `TestRunSummary` type? (I'm not saying you _must_, just asking.)