Jonathan Grynspan
Jonathan Grynspan
@jeffdav Could we ask you to just push additional commits so it's easier for us to see incremental changes? We'll squash the whole thing when we merge the PR. Thanks!
@dabrahams Please read the draft pitch. :) 1. and 2. are covered in it. It sounds like 3. is sufficiently covered I think? `.signal()` is not supported on Windows because...
> I skimmed the pitch; I didn't see coverage for 1; what I saw was > > > The need for exit tests on other platforms is just as strong...
To be clear (I'm now reading my initial reply as snarky, which wasn't intentional), I appreciate the feedback @dabrahams. I can certainly amend the pitch to make it clearer we're...
Something else for you to consider: we should have instructions somewhere (perhaps in a dedicated .md file in Documentation/) showing how to build swift-testing from source using CMake.
Windows signals are now handled! #766
And stdout/stderr will be soon too. #773
Holding off on approval because I am not in a position to audit the CMake bits, not myself understanding anything about CMake. @etcwilde would you please review?
@swift-ci test
@swift-ci please test