graham
graham
I guess one other thing is I don't often like CI jobs that modify files + autocommit after the PR is sent, in ci...another option is to use commit-time checks...
> I'm against any changes being done without logging of what change is being made and why. If something breaks, being able to go back and see what made the...
I also kinda call into question this specific feedback as being a maximalist or extremist overreaction or anything of the sort tbh - venturing the conversation there to that vantage...
@northeastprince Do we plan on moving forward with small changes to this PR?
> I was waiting for a response to my comment - sorry if that was unclear. Just to clear things up from what I presume to be the main source...
Either that, or resolve the commentary with changes to the PR.
@malted I assume you mean this feature of octodns? https://github.com/octodns/octodns#automatic-ptr-generation
Agreed.
At first glance - this seems a major version upgrade that fails to deploy w/ things that seem related to the upgraded library.
navigated to multiple pages, seemed fine