terratest Move GCP related resources to separate dir

Related to issue #600

Oct 19 '20 19:10 StupidScience

I'm in favor of this, but I guess we should also add build tags similar to how we handle Azure in order to future proof it. @yorinasub17 thoughts?

@StupidScience did the tests pass correctly?

Oct 20 '20 05:10 robmorgan

@robmorgan I've moved default packer variables to separate dir and now it works fine. Also // +build gcp tag added

Oct 20 '20 08:10 StupidScience

I'm in favor of this 👍

Note that this only partially fixes #600, so @StupidScience, could you rephrase your PR description so that issue isn't auto-closed when this PR is merged?

@robmorgan, I'll let you take it from here, run tests, etc.

Oct 20 '20 09:10 brikis98

@brikis98 what should I do to prevent issue autoclosing? Just remove issue reference?

Oct 20 '20 09:10 StupidScience

Yup! Or remove the word "fixes" as I think that's one of the keywords GitHub looks for in PR descriptions.

Oct 20 '20 10:10 brikis98

@brikis98 done

Oct 20 '20 10:10 StupidScience

Thanks!

Oct 20 '20 10:10 brikis98

This LGTM! However, before we can kick off our build, I think the circleci config will need some surgery to make sure it runs the new test/gcp package.

Oct 27 '20 16:10 yorinasub17