terragrunt icon indicating copy to clipboard operation
terragrunt copied to clipboard

Published 20 hours ago • verified publisher icon gruntwork-io

based on reported issue #2158, removed the trailing slash appended to get_path_to_repo_root()

Open eightseventhreethree opened this issue 3 years ago • 2 comments

and updated tests to match

Description

Fixes #2158.

TODOs

Read the Gruntwork contribution guidelines.

  • [x] Update the docs. (Docs already show this desired state)
  • [x] Run the relevant tests successfully, including pre-commit checks.
  • [x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • [x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes

  • Removes trailing slash appended to the end of get_path_to_repo_root()

Added / Removed / Updated [].

Migration Guide

  • Migration:
    • source = "${get_path_to_repo_root()}/ -> source = "${get_path_to_repo_root()}//

eightseventhreethree avatar Jul 25 '22 13:07 eightseventhreethree

@yorinasub17 @zackproser @rhoboat @denis256 Hey, is there anything else required to get this merged?

eightseventhreethree avatar Aug 30 '22 13:08 eightseventhreethree

Hi, I will review soon this PR too

denis256 avatar Aug 30 '22 17:08 denis256

@denis256 Any updates?

eightseventhreethree avatar Sep 26 '22 17:09 eightseventhreethree

@denis256 @levkohimins Any updates on this? Just spent a few hours debugging only to eventually discover the issue and related PR are extremely simple which is really disheartening...

jarpoole avatar Sep 09 '23 16:09 jarpoole

@eightseventhreethree, thanks for the PR! I had to create another PR to improve the integration test since I couldn't change your PR (branch).

lev-ok avatar Sep 18 '23 19:09 lev-ok

Resolved in v0.51.1 release.

lev-ok avatar Sep 18 '23 19:09 lev-ok

Really appreciate you following up! Thanks for all the hard work on this amazing tool 🙂

jarpoole avatar Sep 18 '23 21:09 jarpoole