terraform-aws-utilities icon indicating copy to clipboard operation
terraform-aws-utilities copied to clipboard

Add VPC and IAM resources to request_quota_increase + code gen script

Open marinalimeira opened this issue 4 years ago • 9 comments

THIS PR IS BACKWARDS INCOMPATIBLE the existing keys, nat_gateway and nacl_rules, were changed.

This is an improvement of #38.

Changes:

  • New script to generate code to generate the necessary code to add a new resource
  • No need to use the 'Service Code' to lookup for resources, using aws_servicequotas_service_quota.
  • nat_gateway renamed to vpc_nat_gateways_per_availability_zone to follow new pattern
  • nacl_rules renamed to vpc_rules_per_network_acl to follow new pattern

marinalimeira avatar Feb 12 '21 15:02 marinalimeira

@marinalimeira This is an old PR, but I like the changes. Can we fix the conflicts, merge this up and take care of NITs later?

rhoboat avatar Jun 17 '22 19:06 rhoboat

Upgrade test results for build 417

⚠️ If plan results are not all 0's, review the plan output to ensure backward compatibility.

Example Modules to upgrade Plan Upgraded? Patched Upgraded?
join-path instance-type
join-path
0, 0, 0 :white_check_mark:
instance-type instance-type
join-path
0, 0, 0 :white_check_mark:

gruntwork-ci avatar Aug 04 '22 13:08 gruntwork-ci

Upgrade test results for build 421

⚠️ If plan results are not all 0's, review the plan output to ensure backward compatibility.

Example Modules to upgrade Plan Upgraded? Patched Upgraded?
join-path instance-type
join-path
0, 0, 0 :white_check_mark:
instance-type instance-type
join-path
0, 0, 0 :white_check_mark:

gruntwork-ci avatar Aug 04 '22 13:08 gruntwork-ci

Upgrade test results for build 425

⚠️ If plan results are not all 0's, review the plan output to ensure backward compatibility.

Example Modules to upgrade Plan Upgraded? Patched Upgraded?
join-path instance-type
join-path
0, 0, 0 :white_check_mark:
instance-type instance-type
join-path
0, 0, 0 :white_check_mark:

gruntwork-ci avatar Aug 04 '22 13:08 gruntwork-ci

Hm, the tests are failing, I just locked the region to us-east-1...

marinalimeira avatar Aug 05 '22 13:08 marinalimeira

Upgrade test results for build 431

⚠️ If plan results are not all 0's, review the plan output to ensure backward compatibility.

Example Modules to upgrade Plan Upgraded? Patched Upgraded?
join-path instance-type
join-path
0, 0, 0 :white_check_mark:
instance-type instance-type
join-path
0, 0, 0 :white_check_mark:

gruntwork-ci avatar Aug 05 '22 13:08 gruntwork-ci

It is still failing but it works locally for me... I will investigate this on Monday.

marinalimeira avatar Aug 05 '22 15:08 marinalimeira

Sooooo... I finally took the proper time to take a look at this. I was running the tests in the wrong branch, that's why it was working locally...

Well, there was a tiny typo in the test, it's fixed now! cb40b56 Tests will hopefully pass in this run and we can merge it!

@rhoboat can you take a final look? :)

marinalimeira avatar Aug 16 '22 13:08 marinalimeira

Upgrade test results for build 436

⚠️ If plan results are not all 0's, review the plan output to ensure backward compatibility.

Example Modules to upgrade Plan Upgraded? Patched Upgraded?
join-path instance-type
join-path
0, 0, 0 :white_check_mark:
instance-type instance-type
join-path
0, 0, 0 :white_check_mark:

gruntwork-ci avatar Aug 16 '22 13:08 gruntwork-ci

@marinalimeira Closing this as part of a PR clean-up initiative. Feel free to re-open if you continue to plan on working on this!

MoonMoon1919 avatar Mar 29 '23 18:03 MoonMoon1919