terraform-aws-couchbase icon indicating copy to clipboard operation
terraform-aws-couchbase copied to clipboard

Possibility of passing in tags for security group in couchbase-cluster module

Open schroerbrian opened this issue 6 years ago • 1 comments

Hello,

My team has pretty strict tagging guidelines, and I was wondering if it'd be possible to add another argument to the couchbase-cluster module, say, security_group_tags that would be passed to the aws_security_group.lc_security_group resource tags argument to allow tagging.

On a separate but related note, would it be possible to have the option to use a name rather than name_prefix in the aws_security_group.lc_security_group resource?

Thanks, Brian

N.B. I'd be happy to submit the PR, if desired

schroerbrian avatar Feb 01 '19 20:02 schroerbrian

Hi! Tags for the security groups makes perfect sense. A PR for that is very welcome!

I believe we use name_prefix because the Security Group sets create_before_destroy = true, and if you change the name and it tries to recreate it, you get an error that the security group already exists.

brikis98 avatar Feb 01 '19 22:02 brikis98

This repo is being archived, feel free to use a fork if necessary.

ellisonc avatar Mar 29 '23 18:03 ellisonc