helm-kubernetes-services icon indicating copy to clipboard operation
helm-kubernetes-services copied to clipboard

Published 20 hours ago • verified publisher icon gruntwork-io

Label deployment and pod with app.kubernetes.io/version

Open mloskot opened this issue 5 months ago • 0 comments

Describe the solution you'd like

The chart already generates a bunch of well-known and recommended Kubernetes labels:

https://github.com/gruntwork-io/helm-kubernetes-services/blob/8a50e60380ddfe294e36a824ece771012ea483c2/charts/k8s-service/templates/_deployment_spec.tpl#L88-L90

It seems reasonable to allow users feed the chart with values for additional well-known labels like app.kubernetes.io/version

Describe alternatives you've considered

It is possible to inject the requested app.kubernetes.io/version label with additionalDeploymentLabels and additionalPodLabels, but allowing users to specify version as a dedicated Helm value seems reasonable in the spirit of all app.kubernetes.io labels or none.

Additional context

n/a

mloskot avatar Sep 13 '24 15:09 mloskot