helm-kubernetes-services icon indicating copy to clipboard operation
helm-kubernetes-services copied to clipboard

Use 'ingressClassName' instead deprecated annotation "kubernetes.io/ingress.class"

Open nadiia-kotelnikova opened this issue 1 year ago • 3 comments

Describe the solution you'd like I've noticed the warning during a chart deployment:

W0612 15:00:09.676081    1973 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead

The kubernetes.io/ingress.class annotation is deprecated since Kubernetes v1.18 , also a deprecation notes in AWS load balancer.

So we might add the spec.ingressClassName field to the Ingress template.

nadiia-kotelnikova avatar Jun 13 '24 10:06 nadiia-kotelnikova

Hi @nadiia-caspar, thanks for opening this issue!

This should def be updated. We will get it into the backlog for one of the upcoming sprints. We do welcome PR's as well if you are interested in contributing an update for this 😄

ryehowell avatar Jun 21 '24 01:06 ryehowell

@ryehowell i could try to create a PR. But would need so clarification: do you support backward compatibilities? Should the previous way with annotations be supported?

nadiia-kotelnikova avatar Jun 24 '24 10:06 nadiia-kotelnikova

Hi @nadiia-caspar, we always try to maintain as much backwards compatibility as possible, whenever and wherever possible.

ryehowell avatar Jun 25 '24 02:06 ryehowell

@ryehowell thanks for the fix, sorry, lost this issue from my radar

nadiia-kotelnikova avatar Oct 16 '24 11:10 nadiia-kotelnikova