helm-kubernetes-services
helm-kubernetes-services copied to clipboard
Add support for Statefulset deployments
I would like to add support for Statefulset deployments to this helm chart. I believe this can be done with relatively few (and non-breaking?) changes:
- Add an optional field called
workloadType
tovalues.yaml
, where the default value isdeployment
butstatefulset
is also an option. - Add a
_statefulset_spec.tpl
template which gets used whenworkloadType
is set tostatefulset
. In turn,_deployment_spec_tpl
only gets used whenworkloadType
is set todeployment
. - Add an optional
updateStrategy
field tovalues.yaml
which gets injected intoupdateStrategy
onstatefulset
workloads (workloadType: statefulset
).deploymentStrategy
continues getting injected intostrategy
ondeployment
workloads. - Add an optional
name
field underservice
due to Statefulset workload requirements.service
could still haveenabled: false
if the service resource is created outside of the chart.
I consider these changes possibly non-breaking because as long as the default value of workloadType
is deployment
, the chart should behave exactly as it does currently. Also, I don't expect any downtime implications from these changes.
An alternative would be creating different helm charts for statefulset deployments, but I think time will be better spent upgrading this Chart instead.
That being said, is there anything that I'm not seeing that could become a problem with this approach? I'm planning on coding this up soon, but I'd appreciate any feedback 👍🏼.