fetch icon indicating copy to clipboard operation
fetch copied to clipboard

Fetch version constraints tag does not support paging in tags list

Open yorinasub17 opened this issue 5 years ago • 3 comments

If you are referencing a sufficiently old release tag in a version constraints tag, fetch will fail.

Example:

fetch --repo 'https://github.com/gruntwork-io/module-ecs' --tag '~>v0.3.2' foo

fails with:

ERROR: Error occurred while computing latest tag that satisfies version contraint expression: -1 - Tag does not exist

yorinasub17 avatar Dec 07 '18 13:12 yorinasub17

Interesting, this definitely sounds like a bug. All the automated tests on this tool assume a small number of releases, so we didn't explicitly test against large numbers of releases. Perhaps when we fix this, for the failing test first, we can find an open source repo that has a large number of releases and triggers this bug.

josh-padnick avatar Dec 07 '18 15:12 josh-padnick

Could this be a pagination issue? i.e., if there are lots of tags, we are only fetching the first page of results?

brikis98 avatar Dec 07 '18 16:12 brikis98

Yes. Sorry I should have mentioned that in the description, but added that to the title.

yorinasub17 avatar Dec 07 '18 16:12 yorinasub17