cloud-nuke icon indicating copy to clipboard operation
cloud-nuke copied to clipboard

Published 20 hours ago • verified publisher icon gruntwork-io

feature: Adds EFS support

Open GiamPy5 opened this issue 2 years ago • 1 comments

Description

Closes https://github.com/gruntwork-io/cloud-nuke/issues/311.

TODOs

Read the Gruntwork contribution guidelines.

  • [X] Update the docs.
  • [X] Run the relevant tests successfully, including pre-commit checks.
  • [X] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • [X] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added EFS support

Migration Guide

/

GiamPy5 avatar Jun 08 '22 14:06 GiamPy5

Unfortunately the only test I haven't been able to run is TestNukeEFSVolumeWithMountTargets since in our test company's accounts we do not have Default VPC and the test just fails.

GiamPy5 avatar Jun 08 '22 14:06 GiamPy5

@GiampaoloFalqui Can you resolve the merge conflicts and address the review comments if this is still a feature you need. We will be closing stale PRs soon.

ellisonc avatar Apr 06 '23 15:04 ellisonc