grunt-contrib-watch icon indicating copy to clipboard operation
grunt-contrib-watch copied to clipboard

Published 20 hours ago • verified publisher icon gruntjs

Check for nonexistent targets

Open tandrewnichols opened this issue 7 years ago • 4 comments

This addresses #406. However, I do have questions.

  1. I'm not positive that grunt.fail.fatal is the right approach. Maybe it should just do nothing and move on to the next task?

  2. I've never used nodeunit and am finding writing a test for this a bit intimidating. Can someone help me understand how to get started?

  3. I understand that I need to sign the CLA to contribute. However, the link on gruntjs.com/contributing goes to an info page saying DojoFoundation is now part of JSFoundation, and I can't find a place to sign and submit on JSFoundation. I may have already done this (I've done grunt-contrib PRs before I think), but I'm also not sure where to check for that.

tandrewnichols avatar Dec 08 '16 18:12 tandrewnichols

CLA assistant check
All committers have signed the CLA.

jsf-clabot avatar Dec 08 '16 18:12 jsf-clabot

Well, that was a helpful response. Thanks @jsf-clabot.

tandrewnichols avatar Dec 08 '16 18:12 tandrewnichols

FWIW, I have manually tested this in the repository in which I initially noticed the cycle, and it is working.

tandrewnichols avatar Dec 08 '16 18:12 tandrewnichols

I would really like to see this merged...

0815fox avatar Jan 25 '17 13:01 0815fox