grunt-contrib-uglify
grunt-contrib-uglify copied to clipboard
Report not displaying unless --verbose specified
My gruntfile includes the option to display gzip reports for all of my uglified JS files, but they are no longer showing up. It looks like the commit below changed the output to write only on verbose, but I'd think if the report was explicitly specified it should show up regardless.
https://github.com/gruntjs/grunt-contrib-uglify/commit/4944e2c547858656af36098202022e22cb1fdbe2
I can understand wanting to have less output, but if someone specifies that the report should be displayed, it shouldn't require --verbose to show it.
Here is the uglify options block from my gruntfile:
options: {
compress: {
drop_console: true,
screw_ie8: true,
warnings: false
},
mangle: {
except: ['jQuery', 'Backbone']
},
report: 'min'
},
Related https://github.com/gruntjs/grunt-contrib-uglify/issues/249
I, too, believe the output file should be logged in without verbose.
Even beyond that, the report is not displayed at all. Looking at the output again, I noticed that specifying report: 'min' or report: 'gzip' does not produce any report whatsoever, regardless of whether --verbose was specified.
@vladikoff Should I update the title of the issue to reflect that reports are no longer being generated at all, regardless of verbosity?
+1 to fixing this issue. The docs don't mention any requirement for verbose mode, meaning many will assume it's broken.
+1
+1 for non-verbose report output. The default report might be better as falsy, with non-empty values for report showing non-verbose output.
:+1:
I commented on 4944e2c a few months ago that I wanted to do a PR to make an option to have the minification data in the general log and not in grunt's verbose log. Based on the feedback, I did not.
My opinion is that the minification data is significant enough to not have to use grunt --verbose AND add an option to the gruntfile just to get it.
IMO this is important info and should be shown without a switch at all.
+1 for @XhmikosR and @zachleat I miss it, thought it is a bug.
I submitted a pull request (#288 above) which will hopefully be accepted and make both parties happy.
:+1: for a fix
:+1: for a fix
:+1:
One has to google where did the report output go to find that the report option is useless now without being verbose (at least update the docs). I believe people don't want two switches to turn this report on. Plus, we don't need entire verbose info if I just want to get the gzip report..
+1 for a fix
Hey all. Wondering if someone knows the answer to this.
Did this task use to say the difference in size by default? I swear i used to see it, but i can't remember. If so, what were the reasons to take it out? Mostly just curious since i am assuming taking it out was due to other reasons i am ignorant to.
got v0.9.2 and info is still not displayed :(
+1 to fix this issue
:+1:
This Bug ist still there... ist there nobody to fix it?
There are differing opinions on what it means to fix it, including mine in #288, which was accepted on March 4th, 2016. The fix was then reverted in #419 in the middle of July.
If i do my task i get no report. But i think there should be a short report about how many files and maybe the size of files before and after in sum should be displayed like in cssmin! Otherwise the report option make no sense. If you set it to 'none' the task can be quiet but not if it is set to min or gzip.
Sorry for that. It seems @vladikoff merged that PR fast. I reverted that PR. Please check and let me know so that I cut a new patch release.
PLease can anyone check this, so that the changes can be released. Seems im to stupid to check that out or there is still no reporting?