grunt-contrib-jshint icon indicating copy to clipboard operation
grunt-contrib-jshint copied to clipboard

Why it was added again peerDependencies ?

Open pine opened this issue 9 years ago • 4 comments

Hi. I think peerDependencies is deprecated but added again in the package.json.

Remove peerDeps. Ref gruntjs/grunt#1116: https://github.com/gruntjs/grunt-contrib-jshint/commit/4557d0440d17383825cb84abede08b90b8b21614 Add grunt >=0.4.0 as a peerDep: https://github.com/gruntjs/grunt-contrib-jshint/commit/a368347ad26380fd2a59dd57bc1ab2e765493808

If it has grunt >= 0.4.0 in peerDependencies, I can't use Grunt v1.0.0-rc1 with npm 2.x.

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants grunt@>=0.4.0

In this environment,

$ node --version
v4.3.2
$ npm --version
2.14.12
$ nvm --version
0.23.3

Thank you.

pine avatar Mar 05 '16 11:03 pine

Thanks for the issue. this is strange @shama :confused:

vladikoff avatar Mar 05 '16 20:03 vladikoff

Wow that is annoying. They are added back in to be consistent with our recommendations. Until grunt is no longer an actual peer dep. >=0.4.0 should match 1.0.0-rc1 but if it doesn't... sigh. I guess we'll have to nuke them or just never release pre-release versions.

shama avatar Mar 06 '16 02:03 shama

Hello @shama,

>=0.4.0 should match 1.0.0-rc1 but if it doesn't... sigh.

That's right! I thought that >=0.4.0 matchs 1.0.0-rc1 but ... I hope that Grunt v1.0 is released quickly.

Thank you.

pine avatar Mar 06 '16 10:03 pine

@shama Grunt passed v1.0.0. any chance of getting this peer dep updated? Thx

zappan avatar May 25 '17 10:05 zappan