grunt-contrib-cssmin icon indicating copy to clipboard operation
grunt-contrib-cssmin copied to clipboard

v0.12.2 Set the rebase option to false by default.

Open jdp999 opened this issue 9 years ago • 5 comments

Doesn't seem to set the option to false by default.

Didn't have this option set to anything before, and seemed to work fine for all my url's. Did a diff on versions of my minified file and on 2/19/2015 file has url exactly as in my source file. Subsequent versions all have modified url.

Switched my grunt file to explicitly set this option false, and my relative url's remained unchanged. Removed this option and url's get changed. Set rebase: true, url's get changed.

Seems like default setting is set as true, but was previously set as false?

jdp999 avatar Feb 27 '15 00:02 jdp999

https://github.com/gruntjs/grunt-contrib-cssmin/commit/77100010d7695d8e36aafef116c25f3922c0762b

// @XhmikosR

sindresorhus avatar Feb 27 '15 06:02 sindresorhus

I (obviously) don't see the same issue. Please share your config.

XhmikosR avatar Feb 27 '15 07:02 XhmikosR

I'm having the same issue - I have to set rebase: false in order to get the same behaviour as in pre-v0.12.2 versions:

    cssmin: {
      options: {
        rebase: false
      },
      dist: {
        expand: true,
        cwd: 'dist/themes/',
        src: ['**/*.css'],
        dest: 'dist/themes/',
        ext: '.min.css'
      }
    }

sattes-faction avatar Mar 02 '15 09:03 sattes-faction

PR welcome; I still don't see the issue here.

XhmikosR avatar Mar 02 '15 09:03 XhmikosR

I was having continued issues with font-awesome in 0.12.2 but resolved them by updating the less @fa-font-path variable. Another option would be to use a grunt-contrib-copy task to copy the font-awesome files from bower_components into the expected directory of ../fonts.

@import "../bower_components/font-awesome/less/font-awesome.less";
@fa-font-path: "../bower_components/font-awesome/fonts";

@kimone hope this helps.

tony99nyr avatar Mar 03 '15 19:03 tony99nyr