grunt-contrib-concat icon indicating copy to clipboard operation
grunt-contrib-concat copied to clipboard

Add new option log

Open paladox opened this issue 9 years ago • 7 comments

The default is set as true.

This is so a user has a choice between verbose or just seeing that the file has been created and dosent't want to see all the information.

Follows up https://github.com/gruntjs/grunt-contrib-concat/pull/145

And fixes https://github.com/gruntjs/grunt-contrib-concat/issues/153

paladox avatar Mar 25 '16 20:03 paladox

@shama or @vladikoff could you review and merge please.

paladox avatar Mar 25 '16 21:03 paladox

I don't think adding more options to plugins is a good way to solve this. We should think through and submit a rfc that gives end users more control over how grunt logs.

shama avatar Mar 25 '16 21:03 shama

Yes currently we carn't see what is created unless we add verbose which not only affects this but affects other scripts showing too much information that we doint want to see.

paladox avatar Mar 25 '16 21:03 paladox

Quoting @vladikoff's comment in #145:

We should also add a total message like other plugins do, i.e "X files created" in the end

This should be the right way to go, without adding any other option.

Arkni avatar Mar 25 '16 21:03 Arkni

I understand. The previous PR changing it to verbose wasn't a good solution either. I think we should come up with a good solution to fix the actual problem, giving users more control over grunt log.

I recommend using a previous version of this plugin in the meantime.

shama avatar Mar 25 '16 21:03 shama

@shama could we revert that change then, and instead follow what you said and improve it in grunt instead please.

paladox avatar Mar 25 '16 21:03 paladox

I understand. The previous PR changing it to verbose wasn't a good solution either. I think we should come up with a good solution to fix the actual problem, giving users more control over grunt log.

Multiple other plugins switched to verbose only, users are concating over 100 files and logging everything by default is not a good solution.

vladikoff avatar Mar 25 '16 23:03 vladikoff