icecream icon indicating copy to clipboard operation
icecream copied to clipboard

Including style in the code is unnecessary

Open commongeek opened this issue 1 year ago • 2 comments

A lot of styles are included in pygments, including solarized-dark (https://pygments.org/styles/).

Instead of putting the entire style code into coloring.py, you can just do something like this:

from pygments.styles import get_style_by_name

style = get_style_by_name('solarized-dark')

commongeek avatar Mar 22 '24 17:03 commongeek

@commongeek great suggestion! simpler is always better 👏

iirc coloring.py has a few differences with solarized-dark to look good in both light and dark terminals

that said, I'm all for simplifying things

might you be up to open a PR that removes coloring.py? or at least simplifies icecream to avoid a bunch of repeat code and colors in coloring.py

gruns avatar Nov 12 '24 16:11 gruns

@commongeek Should we expect a PR from you?

Jakeroid avatar Aug 17 '25 16:08 Jakeroid