furl
furl copied to clipboard
Removes "git@" from git remote URL
Hi, ClearML uses furl to remove a user from a git remote URL, so furl removes username when the remote URL is like "ssh://[email protected]:1234/path/to/repo.git" (with "ssh://git@"):
-
Ok:
furl.furl("[email protected]:1234/path/to/repo.git").remove(username=True, password=True).tostr()
expected: [email protected]:1234/path/to/repo.git received: [email protected]:1234/path/to/repo.git -
Not as expected:
furl.furl("ssh://[email protected]:1234/path/to/repo.git").remove(username=True, password=True).tostr()
expected: ssh://[email protected]:1234/path/to/repo.git received: ssh://0.0.0.0:1234/path/to/repo.git
should I use more specific lib/tool to parse git-like URLs?
To preserve git@
, username
needs to be set to False
.
I believe the second case is the correct behavior, its just that the first example is missing the scheme so that the parser thinks [email protected]
is the scheme which is obviously incorrect.