furl icon indicating copy to clipboard operation
furl copied to clipboard

Published 20 hours ago • verified publisher icon gruns

Add typing support

Open palfrey opened this issue 3 years ago • 6 comments

Currently running mypy against something using this project gets error: Skipping analyzing 'furl': found module but no type hints or library stubs

palfrey avatar Aug 29 '21 15:08 palfrey

do you have the time and bandwidth to add types to icecream? 🙂

gruns avatar Aug 30 '21 22:08 gruns

Turns out it's harder than that. icecream needs executing, which needs asttokens which needs astroid. Astroid has had some typing work, but it still is a way off (see https://github.com/PyCQA/astroid/pull/1024#issuecomment-860230292). OTOH, if we ignore that, the others are more viable.

I've opened https://github.com/gristlabs/asttokens/pull/72 to start this process, but the build system appears a bit broken there.

palfrey avatar Sep 05 '21 15:09 palfrey

@palfrey thank you for your efforts here! 🙌

gruns avatar Sep 10 '21 19:09 gruns

Looks like the asttokens change has been merged.

dsully avatar Sep 30 '22 17:09 dsully

Yup. https://github.com/alexmojaki/executing/pull/57 is my initial work there

palfrey avatar Oct 01 '22 22:10 palfrey

And icecream with https://github.com/gruns/icecream/pull/167

palfrey avatar Nov 24 '23 00:11 palfrey